Re: [PATCH] libnvdimm: rework region badblocks clearing

2017-05-01 Thread Dan Williams
On Mon, May 1, 2017 at 2:26 PM, Kani, Toshimitsu wrote: > On Sun, 2017-04-30 at 05:39 -0700, Dan Williams wrote: >> Toshi noticed that the new support for a region-level badblocks >> missed the case where errors are cleared due to BTT I/O. >> >> An initial attempt to fix this ran into a "sleeping

Re: [PATCH] libnvdimm: rework region badblocks clearing

2017-05-01 Thread Kani, Toshimitsu
On Sun, 2017-04-30 at 05:39 -0700, Dan Williams wrote: > Toshi noticed that the new support for a region-level badblocks > missed the case where errors are cleared due to BTT I/O. > > An initial attempt to fix this ran into a "sleeping while atomic" > warning due to taking the nvdimm_bus_lock() in

Re: [PATCH] libnvdimm: rework region badblocks clearing

2017-05-01 Thread Kani, Toshimitsu
On Mon, 2017-05-01 at 16:42 +, Verma, Vishal L wrote: > On Mon, 2017-05-01 at 09:38 -0700, Dan Williams wrote: > > On Mon, May 1, 2017 at 9:20 AM, Kani, Toshimitsu > > : > > > > > > > > Hi Dan, > > > > > > > > > > > > > > > > I was testing the change with CONFIG_DEBUG_ATOMIC_SLEEP > > > > >

Re: [PATCH] libnvdimm: rework region badblocks clearing

2017-05-01 Thread Verma, Vishal L
On Mon, 2017-05-01 at 09:38 -0700, Dan Williams wrote: > On Mon, May 1, 2017 at 9:20 AM, Kani, Toshimitsu > wrote: > > On Mon, 2017-05-01 at 09:16 -0700, Dan Williams wrote: > > > On Mon, May 1, 2017 at 9:12 AM, Kani, Toshimitsu > > com> > > > wrote: > > > > On Mon, 2017-05-01 at 08:52 -0700, Dan

Re: [PATCH] libnvdimm: rework region badblocks clearing

2017-05-01 Thread Dan Williams
On Mon, May 1, 2017 at 9:20 AM, Kani, Toshimitsu wrote: > On Mon, 2017-05-01 at 09:16 -0700, Dan Williams wrote: >> On Mon, May 1, 2017 at 9:12 AM, Kani, Toshimitsu >> wrote: >> > On Mon, 2017-05-01 at 08:52 -0700, Dan Williams wrote: >> > > On Mon, May 1, 2017 at 8:43 AM, Dan Williams > > > l.co

Re: [PATCH] libnvdimm: rework region badblocks clearing

2017-05-01 Thread Kani, Toshimitsu
On Mon, 2017-05-01 at 09:16 -0700, Dan Williams wrote: > On Mon, May 1, 2017 at 9:12 AM, Kani, Toshimitsu > wrote: > > On Mon, 2017-05-01 at 08:52 -0700, Dan Williams wrote: > > > On Mon, May 1, 2017 at 8:43 AM, Dan Williams > > l.co > > > m> wrote: > > > > On Mon, May 1, 2017 at 8:34 AM, Kani, T

Re: [PATCH] libnvdimm: rework region badblocks clearing

2017-05-01 Thread Dan Williams
On Mon, May 1, 2017 at 9:12 AM, Kani, Toshimitsu wrote: > On Mon, 2017-05-01 at 08:52 -0700, Dan Williams wrote: >> On Mon, May 1, 2017 at 8:43 AM, Dan Williams > m> wrote: >> > On Mon, May 1, 2017 at 8:34 AM, Kani, Toshimitsu > > m> wrote: >> > > On Sun, 2017-04-30 at 05:39 -0700, Dan Williams wr

Re: [PATCH] libnvdimm: rework region badblocks clearing

2017-05-01 Thread Kani, Toshimitsu
On Mon, 2017-05-01 at 08:52 -0700, Dan Williams wrote: > On Mon, May 1, 2017 at 8:43 AM, Dan Williams m> wrote: > > On Mon, May 1, 2017 at 8:34 AM, Kani, Toshimitsu > m> wrote: > > > On Sun, 2017-04-30 at 05:39 -0700, Dan Williams wrote: : > > > > > > Hi Dan, > > > > > > I was testing the chan

Re: [PATCH] libnvdimm: rework region badblocks clearing

2017-05-01 Thread Dan Williams
On Mon, May 1, 2017 at 8:43 AM, Dan Williams wrote: > On Mon, May 1, 2017 at 8:34 AM, Kani, Toshimitsu wrote: >> On Sun, 2017-04-30 at 05:39 -0700, Dan Williams wrote: >>> Toshi noticed that the new support for a region-level badblocks >>> missed the case where errors are cleared due to BTT I/O.

Re: [PATCH] libnvdimm: rework region badblocks clearing

2017-05-01 Thread Kani, Toshimitsu
On Sun, 2017-04-30 at 05:39 -0700, Dan Williams wrote: > Toshi noticed that the new support for a region-level badblocks > missed the case where errors are cleared due to BTT I/O. > > An initial attempt to fix this ran into a "sleeping while atomic" > warning due to taking the nvdimm_bus_lock() in

Re: [PATCH] libnvdimm: rework region badblocks clearing

2017-05-01 Thread Dan Williams
On Mon, May 1, 2017 at 8:34 AM, Kani, Toshimitsu wrote: > On Sun, 2017-04-30 at 05:39 -0700, Dan Williams wrote: >> Toshi noticed that the new support for a region-level badblocks >> missed the case where errors are cleared due to BTT I/O. >> >> An initial attempt to fix this ran into a "sleeping