Re: [PATCH] locking/lockdep: Add debug_locks check in __lock_downgrade()

2019-01-19 Thread Tetsuo Handa
Peter, will this fix be sent to linux.git shortly? syzbot is generating many corrupted reports due to this race. On 2019/01/14 22:36, Peter Zijlstra wrote: > On Thu, Jan 10, 2019 at 11:21:13AM +0100, Dmitry Vyukov wrote: >> On Thu, Jan 10, 2019 at 5:04 AM Waiman Long wrote: >>> >>> Tetsuo Handa h

Re: [PATCH] locking/lockdep: Add debug_locks check in __lock_downgrade()

2019-01-14 Thread Dmitry Vyukov
On Mon, Jan 14, 2019 at 2:37 PM Peter Zijlstra wrote: > > On Thu, Jan 10, 2019 at 11:21:13AM +0100, Dmitry Vyukov wrote: > > On Thu, Jan 10, 2019 at 5:04 AM Waiman Long wrote: > > > > > > Tetsuo Handa had reported he saw an incorrect "downgrading a read lock" > > > warning right after a previous

Re: [PATCH] locking/lockdep: Add debug_locks check in __lock_downgrade()

2019-01-14 Thread Peter Zijlstra
On Thu, Jan 10, 2019 at 11:21:13AM +0100, Dmitry Vyukov wrote: > On Thu, Jan 10, 2019 at 5:04 AM Waiman Long wrote: > > > > Tetsuo Handa had reported he saw an incorrect "downgrading a read lock" > > warning right after a previous lockdep warning. It is likely that the > > previous warning turned

Re: [PATCH] locking/lockdep: Add debug_locks check in __lock_downgrade()

2019-01-14 Thread Tetsuo Handa
On 2019/01/10 19:21, Dmitry Vyukov wrote: >> @@ -3535,6 +3535,9 @@ static int __lock_downgrade(struct lockdep_map *lock, >> unsigned long ip) >> unsigned int depth; >> int i; >> >> + if (unlikely(!debug_locks)) >> + return 0; >> + > > Are we sure this resolves

Re: [PATCH] locking/lockdep: Add debug_locks check in __lock_downgrade()

2019-01-10 Thread Dmitry Vyukov
On Thu, Jan 10, 2019 at 5:04 AM Waiman Long wrote: > > Tetsuo Handa had reported he saw an incorrect "downgrading a read lock" > warning right after a previous lockdep warning. It is likely that the > previous warning turned off lock debugging causing the lockdep to have > inconsistency states lea