Re: [PATCH] locking/lockdep: Dump state of percpu_rwsem upon hung up.

2018-07-10 Thread Peter Zijlstra
On Tue, Jul 10, 2018 at 07:48:31PM +0900, Tetsuo Handa wrote: > Should I update > "[PATCH] locking/lockdep: Dump state of percpu_rwsem upon hung up." side > to use "#ifndef CONFIG_RWSEM_GENERIC_SPINLOCK" ? Since it's a debug patch, who cares if there's a config for which it doesn't build?

Re: [PATCH] locking/lockdep: Dump state of percpu_rwsem upon hung up.

2018-07-10 Thread Tetsuo Handa
On 2018/07/10 18:30, Peter Zijlstra wrote: >> diff --git a/include/linux/rwsem-spinlock.h b/include/linux/rwsem-spinlock.h >> index e475683..1164965 100644 >> --- a/include/linux/rwsem-spinlock.h >> +++ b/include/linux/rwsem-spinlock.h >> @@ -22,7 +22,7 @@ >> * - if wait_list is not empty, then t

Re: [PATCH] locking/lockdep: Dump state of percpu_rwsem upon hung up.

2018-07-10 Thread Peter Zijlstra
On Tue, Jul 10, 2018 at 03:10:51PM +0900, Tetsuo Handa wrote: > From 2642b4a1904259384f2018ea8df03ac49509c57a Mon Sep 17 00:00:00 2001 > From: Tetsuo Handa > Date: Tue, 10 Jul 2018 15:01:20 +0900 > Subject: [PATCH] locking/rwsem: Convert the other sem->count to > 'atomic_long_t' > > Since "locki

Re: [PATCH] locking/lockdep: Dump state of percpu_rwsem upon hung up.

2018-07-10 Thread Will Deacon
On Tue, Jul 10, 2018 at 03:10:51PM +0900, Tetsuo Handa wrote: > From 2642b4a1904259384f2018ea8df03ac49509c57a Mon Sep 17 00:00:00 2001 > From: Tetsuo Handa > Date: Tue, 10 Jul 2018 15:01:20 +0900 > Subject: [PATCH] locking/rwsem: Convert the other sem->count to > 'atomic_long_t' > > Since "locki

Re: [PATCH] locking/lockdep: Dump state of percpu_rwsem upon hung up.

2018-07-09 Thread Tetsuo Handa
>From 2642b4a1904259384f2018ea8df03ac49509c57a Mon Sep 17 00:00:00 2001 From: Tetsuo Handa Date: Tue, 10 Jul 2018 15:01:20 +0900 Subject: [PATCH] locking/rwsem: Convert the other sem->count to 'atomic_long_t' Since "locking/rwsem: Convert sem->count to 'atomic_long_t'" forgot to convert "struct r

Re: [PATCH] locking/lockdep: Dump state of percpu_rwsem upon hung up.

2018-07-07 Thread Tetsuo Handa
Hello. Thanks for doing build test, but I don't understand what is wrong. As far as I can see, "struct percpu_rw_semaphore" contains "struct rw_semaphore" and "struct rw_semaphore" contains "atomic_long_t count". Then, why trying to read using atomic_long_read(&sem->rw_sem.count) causes note: e

Re: [PATCH] locking/lockdep: Dump state of percpu_rwsem upon hung up.

2018-07-07 Thread kbuild test robot
Hi Tetsuo, I love your patch! Yet something to improve: [auto build test ERROR on next-20180706] [also build test ERROR on v4.18-rc3] [cannot apply to tip/auto-latest tip/sched/core linus/master v4.18-rc3 v4.18-rc2 v4.18-rc1] [if your patch is applied to the wrong git tree, please drop us a note