Re: [PATCH] media: em28xx: fix memory leak

2021-04-06 Thread Hans Verkuil
On 06/04/2021 11:44, Muhammad Usama Anjum wrote: > On Wed, 2021-03-31 at 13:22 +0500, Muhammad Usama Anjum wrote: >> On Wed, 2021-03-24 at 23:07 +0500, Muhammad Usama Anjum wrote: >>> If some error occurs, URB buffers should also be freed. If they aren't >>> freed with the dvb here, the em28xx_dvb_

Re: [PATCH] media: em28xx: fix memory leak

2021-04-06 Thread Muhammad Usama Anjum
On Wed, 2021-03-31 at 13:22 +0500, Muhammad Usama Anjum wrote: > On Wed, 2021-03-24 at 23:07 +0500, Muhammad Usama Anjum wrote: > > If some error occurs, URB buffers should also be freed. If they aren't > > freed with the dvb here, the em28xx_dvb_fini call doesn't frees the URB > > buffers as dvb i

Re: [PATCH] media: em28xx: fix memory leak

2021-03-31 Thread Dan Carpenter
On Wed, Mar 31, 2021 at 01:22:01PM +0500, Muhammad Usama Anjum wrote: > On Wed, 2021-03-24 at 23:07 +0500, Muhammad Usama Anjum wrote: > > If some error occurs, URB buffers should also be freed. If they aren't > > freed with the dvb here, the em28xx_dvb_fini call doesn't frees the URB > > buffers a

Re: [PATCH] media: em28xx: fix memory leak

2021-03-31 Thread Muhammad Usama Anjum
On Wed, 2021-03-24 at 23:07 +0500, Muhammad Usama Anjum wrote: > If some error occurs, URB buffers should also be freed. If they aren't > freed with the dvb here, the em28xx_dvb_fini call doesn't frees the URB > buffers as dvb is set to NULL. The function in which error occurs should > do all the c

Re: [PATCH] media: em28xx: fix memory leak

2021-03-22 Thread Muhammad Usama Anjum
On Mon, 2021-03-22 at 19:54 +0500, Muhammad Usama Anjum wrote: > If some error occurs, URB buffers should also be freed. If they aren't > freed with the dvb here, the em28xx_dvb_fini call doesn't frees the URB > buffers as dvb is set to NULL. The function in which error occurs should > do all the c