Re: [PATCH] media: ov7670: check status of ov7670_read

2020-10-06 Thread Tom Rix
On 10/6/20 5:41 AM, Sakari Ailus wrote: > Hi Tom, > > On Fri, Aug 28, 2020 at 07:55:18AM -0700, t...@redhat.com wrote: >> From: Tom Rix >> >> clang static analysis flags this representative problem >> >> drivers/media/i2c/ov7670.c:1463:9: warning: Assigned >> value is garbage or undefined >>

Re: [PATCH] media: ov7670: check status of ov7670_read

2020-10-06 Thread Sakari Ailus
Hi Tom, On Fri, Aug 28, 2020 at 07:55:18AM -0700, t...@redhat.com wrote: > From: Tom Rix > > clang static analysis flags this representative problem > > drivers/media/i2c/ov7670.c:1463:9: warning: Assigned > value is garbage or undefined > *value = gain; >^ > > g

Re: [PATCH] media: ov7670: check status of ov7670_read

2020-08-28 Thread Tom Rix
On 8/28/20 8:13 AM, Nick Desaulniers wrote: > On Fri, Aug 28, 2020 at 7:55 AM wrote: >> From: Tom Rix >> >> clang static analysis flags this representative problem >> >> drivers/media/i2c/ov7670.c:1463:9: warning: Assigned >> value is garbage or undefined >> *value = gain; >>

Re: [PATCH] media: ov7670: check status of ov7670_read

2020-08-28 Thread Nick Desaulniers
On Fri, Aug 28, 2020 at 7:55 AM wrote: > > From: Tom Rix > > clang static analysis flags this representative problem > > drivers/media/i2c/ov7670.c:1463:9: warning: Assigned > value is garbage or undefined > *value = gain; >^ > > gain is set by a successful call to