Re: [PATCH] media: venus: fix duplicated code for different branches

2017-08-18 Thread Gustavo A. R. Silva
Hi Stanimir, On 08/18/2017 02:52 AM, Stanimir Varbanov wrote: Hi Gustavo, On 08/18/2017 02:12 AM, Gustavo A. R. Silva wrote: Refactor code in order to avoid identical code for different branches. This issue was detected with the help of Coccinelle. Addresses-Coverity-ID: 1415317 Signed-off-b

Re: [PATCH] media: venus: fix duplicated code for different branches

2017-08-18 Thread Stanimir Varbanov
Hi Gustavo, On 08/18/2017 02:12 AM, Gustavo A. R. Silva wrote: > Refactor code in order to avoid identical code for different branches. > > This issue was detected with the help of Coccinelle. > > Addresses-Coverity-ID: 1415317 > Signed-off-by: Gustavo A. R. Silva > --- > This code was reported

Re: [PATCH] media: venus: fix duplicated code for different branches

2017-08-17 Thread Hans Verkuil
Stanimir, please review this! I suspect that this is the wrong fix and that the first v4l2_m2m_src_buf_remove_by_buf should be v4l2_m2m_dst_buf_remove_by_buf instead. Regards, Hans On 08/18/2017 01:12 AM, Gustavo A. R. Silva wrote: > Refactor code in order to avoid identical code for dif