Re: [PATCH] memory cgroup: update root memory cgroup when node is onlined

2012-10-18 Thread Johannes Weiner
On Thu, Oct 18, 2012 at 12:03:44PM -0700, Hugh Dickins wrote: > On Tue, 16 Oct 2012, Wen Congyang wrote: > > At 09/14/2012 09:36 AM, Hugh Dickins Wrote: > > > > > > Description to be filled in later: would it be needed for -stable, > > > or is onlining already broken in other ways that you're now

Re: [PATCH] memory cgroup: update root memory cgroup when node is onlined

2012-10-18 Thread Hugh Dickins
On Tue, 16 Oct 2012, Wen Congyang wrote: > At 09/14/2012 09:36 AM, Hugh Dickins Wrote: > > > > Description to be filled in later: would it be needed for -stable, > > or is onlining already broken in other ways that you're now fixing up? > > > > Reported-by: Tang Chen > > Signed-off-by: Hugh Dick

Re: [PATCH] memory cgroup: update root memory cgroup when node is onlined

2012-10-16 Thread Kamezawa Hiroyuki
(2012/09/14 10:36), Hugh Dickins wrote: On Thu, 13 Sep 2012, Johannes Weiner wrote: On Thu, Sep 13, 2012 at 03:14:28PM +0800, Wen Congyang wrote: root_mem_cgroup->info.nodeinfo is initialized when the system boots. But NODE_DATA(nid) is null if the node is not onlined, so root_mem_cgroup->info.

Re: [PATCH] memory cgroup: update root memory cgroup when node is onlined

2012-10-15 Thread Wen Congyang
At 09/14/2012 09:36 AM, Hugh Dickins Wrote: > On Thu, 13 Sep 2012, Johannes Weiner wrote: >> On Thu, Sep 13, 2012 at 03:14:28PM +0800, Wen Congyang wrote: >>> root_mem_cgroup->info.nodeinfo is initialized when the system boots. >>> But NODE_DATA(nid) is null if the node is not onlined, so >>> root_

Re: [PATCH] memory cgroup: update root memory cgroup when node is onlined

2012-09-16 Thread Hugh Dickins
On Fri, 14 Sep 2012, Wen Congyang wrote: > > Hmm, if we don't update lruvec_zone(lruvec) when a node is onlined, > lruver_zone(lruvec) contains a invalid pointer, so we should check > all place that accesses lruvec_zone(lruvec). We store zone in lruvec > but we can't access it. And we can't avoid

Re: [PATCH] memory cgroup: update root memory cgroup when node is onlined

2012-09-16 Thread Wen Congyang
At 09/14/2012 09:36 AM, Hugh Dickins Wrote: > On Thu, 13 Sep 2012, Johannes Weiner wrote: >> On Thu, Sep 13, 2012 at 03:14:28PM +0800, Wen Congyang wrote: >>> root_mem_cgroup->info.nodeinfo is initialized when the system boots. >>> But NODE_DATA(nid) is null if the node is not onlined, so >>> root_

Re: [PATCH] memory cgroup: update root memory cgroup when node is onlined

2012-09-15 Thread Konstantin Khlebnikov
Hugh Dickins wrote: On Thu, 13 Sep 2012, Johannes Weiner wrote: On Thu, Sep 13, 2012 at 03:14:28PM +0800, Wen Congyang wrote: root_mem_cgroup->info.nodeinfo is initialized when the system boots. But NODE_DATA(nid) is null if the node is not onlined, so root_mem_cgroup->info.nodeinfo[nid]->zonei

Re: [PATCH] memory cgroup: update root memory cgroup when node is onlined

2012-09-14 Thread Johannes Weiner
On Thu, Sep 13, 2012 at 06:36:34PM -0700, Hugh Dickins wrote: > On Thu, 13 Sep 2012, Johannes Weiner wrote: > > On Thu, Sep 13, 2012 at 03:14:28PM +0800, Wen Congyang wrote: > > > root_mem_cgroup->info.nodeinfo is initialized when the system boots. > > > But NODE_DATA(nid) is null if the node is no

Re: [PATCH] memory cgroup: update root memory cgroup when node is onlined

2012-09-13 Thread Wen Congyang
At 09/14/2012 09:36 AM, Hugh Dickins Wrote: > On Thu, 13 Sep 2012, Johannes Weiner wrote: >> On Thu, Sep 13, 2012 at 03:14:28PM +0800, Wen Congyang wrote: >>> root_mem_cgroup->info.nodeinfo is initialized when the system boots. >>> But NODE_DATA(nid) is null if the node is not onlined, so >>> root_

Re: [PATCH] memory cgroup: update root memory cgroup when node is onlined

2012-09-13 Thread Wen Congyang
At 09/14/2012 04:59 AM, Johannes Weiner Wrote: > Hi, > > On Thu, Sep 13, 2012 at 03:14:28PM +0800, Wen Congyang wrote: >> root_mem_cgroup->info.nodeinfo is initialized when the system boots. >> But NODE_DATA(nid) is null if the node is not onlined, so >> root_mem_cgroup->info.nodeinfo[nid]->zonein

Re: [PATCH] memory cgroup: update root memory cgroup when node is onlined

2012-09-13 Thread Hugh Dickins
On Thu, 13 Sep 2012, Johannes Weiner wrote: > On Thu, Sep 13, 2012 at 03:14:28PM +0800, Wen Congyang wrote: > > root_mem_cgroup->info.nodeinfo is initialized when the system boots. > > But NODE_DATA(nid) is null if the node is not onlined, so > > root_mem_cgroup->info.nodeinfo[nid]->zoneinfo[zone].

Re: [PATCH] memory cgroup: update root memory cgroup when node is onlined

2012-09-13 Thread Johannes Weiner
Hi, On Thu, Sep 13, 2012 at 03:14:28PM +0800, Wen Congyang wrote: > root_mem_cgroup->info.nodeinfo is initialized when the system boots. > But NODE_DATA(nid) is null if the node is not onlined, so > root_mem_cgroup->info.nodeinfo[nid]->zoneinfo[zone].lruvec.zone contains > an invalid pointer. If w

Re: [PATCH] memory cgroup: update root memory cgroup when node is onlined

2012-09-13 Thread Wen Congyang
At 09/13/2012 06:06 PM, Kamezawa Hiroyuki Wrote: > (2012/09/13 16:14), Wen Congyang wrote: >> root_mem_cgroup->info.nodeinfo is initialized when the system boots. >> But NODE_DATA(nid) is null if the node is not onlined, so >> root_mem_cgroup->info.nodeinfo[nid]->zoneinfo[zone].lruvec.zone contains

Re: [PATCH] memory cgroup: update root memory cgroup when node is onlined

2012-09-13 Thread Kamezawa Hiroyuki
(2012/09/13 16:14), Wen Congyang wrote: root_mem_cgroup->info.nodeinfo is initialized when the system boots. But NODE_DATA(nid) is null if the node is not onlined, so root_mem_cgroup->info.nodeinfo[nid]->zoneinfo[zone].lruvec.zone contains an invalid pointer. If we use numactl to bind a program t