Re: [PATCH] mm, memcg: fix reclaim deadlock with writeback

2018-12-14 Thread Michal Hocko
On Sat 15-12-18 01:13:53, kbuild test robot wrote: > Hi Michal, > > I love your patch! Yet something to improve: Could you point the bot to v3 please? http://lkml.kernel.org/r/20181213092221.27270-1-mho...@kernel.org -- Michal Hocko SUSE Labs

Re: [PATCH] mm, memcg: fix reclaim deadlock with writeback

2018-12-14 Thread kbuild test robot
Hi Michal, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.20-rc6 next-20181214] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits

Re: [PATCH] mm, memcg: fix reclaim deadlock with writeback

2018-12-12 Thread Michal Hocko
On Wed 12-12-18 23:33:10, kbuild test robot wrote: > Hi Michal, > > I love your patch! Yet something to improve: Well, I hate it ;) (like all obviously broken patches) Sorry this is a typo. v2 sent out Thanks! -- Michal Hocko SUSE Labs

Re: [PATCH] mm, memcg: fix reclaim deadlock with writeback

2018-12-12 Thread kbuild test robot
Hi Michal, I love your patch! Yet something to improve: [auto build test ERROR on linus/master] [also build test ERROR on v4.20-rc6 next-20181212] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits

Re: [PATCH] mm, memcg: fix reclaim deadlock with writeback

2018-12-12 Thread Michal Hocko
On Wed 12-12-18 14:58:37, Kirill A. Shutemov wrote: > On Tue, Dec 11, 2018 at 02:26:45PM +0100, Michal Hocko wrote: > > From: Michal Hocko > > > > Liu Bo has experienced a deadlock between memcg (legacy) reclaim and the > > ext4 writeback > > task1: > > [] wait_on_page_bit+0x82/0xa0 > > [] shrink

Re: [PATCH] mm, memcg: fix reclaim deadlock with writeback

2018-12-12 Thread Kirill A. Shutemov
On Tue, Dec 11, 2018 at 02:26:45PM +0100, Michal Hocko wrote: > From: Michal Hocko > > Liu Bo has experienced a deadlock between memcg (legacy) reclaim and the > ext4 writeback > task1: > [] wait_on_page_bit+0x82/0xa0 > [] shrink_page_list+0x907/0x960 > [] shrink_inactive_list+0x2c7/0x680 > [] sh

Re: [PATCH] mm, memcg: fix reclaim deadlock with writeback

2018-12-12 Thread Jan Kara
On Wed 12-12-18 12:42:49, Kirill A. Shutemov wrote: > On Tue, Dec 11, 2018 at 02:26:45PM +0100, Michal Hocko wrote: > > From: Michal Hocko > > > > Liu Bo has experienced a deadlock between memcg (legacy) reclaim and the > > ext4 writeback > > task1: > > [] wait_on_page_bit+0x82/0xa0 > > [] shrink

Re: [PATCH] mm, memcg: fix reclaim deadlock with writeback

2018-12-12 Thread Michal Hocko
On Wed 12-12-18 12:42:49, Kirill A. Shutemov wrote: > On Tue, Dec 11, 2018 at 02:26:45PM +0100, Michal Hocko wrote: > > From: Michal Hocko > > > > Liu Bo has experienced a deadlock between memcg (legacy) reclaim and the > > ext4 writeback > > task1: > > [] wait_on_page_bit+0x82/0xa0 > > [] shrink

Re: [PATCH] mm, memcg: fix reclaim deadlock with writeback

2018-12-12 Thread Kirill A. Shutemov
On Tue, Dec 11, 2018 at 02:26:45PM +0100, Michal Hocko wrote: > From: Michal Hocko > > Liu Bo has experienced a deadlock between memcg (legacy) reclaim and the > ext4 writeback > task1: > [] wait_on_page_bit+0x82/0xa0 > [] shrink_page_list+0x907/0x960 > [] shrink_inactive_list+0x2c7/0x680 > [] sh

Re: [PATCH] mm, memcg: fix reclaim deadlock with writeback

2018-12-11 Thread Jan Kara
On Tue 11-12-18 17:21:49, Michal Hocko wrote: > On Tue 11-12-18 18:15:42, Kirill A. Shutemov wrote: > > For instance, DAX page fault will setup page table entry on its own and > > return VM_FAULT_NOPAGE. It uses vmf_insert_mixed() to setup the page table > > and ignores your pre-allocated page tabl

Re: [PATCH] mm, memcg: fix reclaim deadlock with writeback

2018-12-11 Thread Michal Hocko
On Tue 11-12-18 18:15:42, Kirill A. Shutemov wrote: > On Tue, Dec 11, 2018 at 02:26:45PM +0100, Michal Hocko wrote: [...] > > --- a/mm/memory.c > > +++ b/mm/memory.c > > @@ -2993,6 +2993,17 @@ static vm_fault_t __do_fault(struct vm_fault *vmf) > > struct vm_area_struct *vma = vmf->vma; > >

Re: [PATCH] mm, memcg: fix reclaim deadlock with writeback

2018-12-11 Thread Kirill A. Shutemov
On Tue, Dec 11, 2018 at 02:26:45PM +0100, Michal Hocko wrote: > From: Michal Hocko > > Liu Bo has experienced a deadlock between memcg (legacy) reclaim and the > ext4 writeback > task1: > [] wait_on_page_bit+0x82/0xa0 > [] shrink_page_list+0x907/0x960 > [] shrink_inactive_list+0x2c7/0x680 > [] sh