Re: [PATCH] mm/rmap: fix BUG at rmap_walk

2013-12-18 Thread Dave Jones
On Wed, Dec 18, 2013 at 04:50:49PM -0800, Andrew Morton wrote: > On Wed, 18 Dec 2013 19:41:44 -0500 Sasha Levin > wrote: > > > On 12/18/2013 07:28 PM, Andrew Morton wrote: > > > On Thu, 19 Dec 2013 08:16:35 +0800 Wanpeng Li > > > wrote: > > > > > >> page_get_anon_vma() called in page_r

Re: [PATCH] mm/rmap: fix BUG at rmap_walk

2013-12-18 Thread Joonsoo Kim
On Wed, Dec 18, 2013 at 05:04:29PM -0800, Andrew Morton wrote: > On Thu, 19 Dec 2013 09:58:05 +0900 Joonsoo Kim wrote: > > > On Wed, Dec 18, 2013 at 04:28:58PM -0800, Andrew Morton wrote: > > > On Thu, 19 Dec 2013 08:16:35 +0800 Wanpeng Li > > > wrote: > > > > > > > page_get_anon_vma() called

Re: [PATCH] mm/rmap: fix BUG at rmap_walk

2013-12-18 Thread Andrew Morton
On Thu, 19 Dec 2013 09:58:05 +0900 Joonsoo Kim wrote: > On Wed, Dec 18, 2013 at 04:28:58PM -0800, Andrew Morton wrote: > > On Thu, 19 Dec 2013 08:16:35 +0800 Wanpeng Li > > wrote: > > > > > page_get_anon_vma() called in page_referenced_anon() will lock and > > > increase the refcount of anon_

Re: [PATCH] mm/rmap: fix BUG at rmap_walk

2013-12-18 Thread Joonsoo Kim
Hello, Andrew. On Wed, Dec 18, 2013 at 04:28:58PM -0800, Andrew Morton wrote: > On Thu, 19 Dec 2013 08:16:35 +0800 Wanpeng Li > wrote: > > > page_get_anon_vma() called in page_referenced_anon() will lock and > > increase the refcount of anon_vma, page won't be locked for anonymous > > page. T

Re: [PATCH] mm/rmap: fix BUG at rmap_walk

2013-12-18 Thread Andrew Morton
On Wed, 18 Dec 2013 19:41:44 -0500 Sasha Levin wrote: > On 12/18/2013 07:28 PM, Andrew Morton wrote: > > On Thu, 19 Dec 2013 08:16:35 +0800 Wanpeng Li > > wrote: > > > >> page_get_anon_vma() called in page_referenced_anon() will lock and > >> increase the refcount of anon_vma, page won't be loc

Re: [PATCH] mm/rmap: fix BUG at rmap_walk

2013-12-18 Thread Sasha Levin
On 12/18/2013 07:28 PM, Andrew Morton wrote: On Thu, 19 Dec 2013 08:16:35 +0800 Wanpeng Li wrote: page_get_anon_vma() called in page_referenced_anon() will lock and increase the refcount of anon_vma, page won't be locked for anonymous page. This patch fix it by skip check anonymous page locked

Re: [PATCH] mm/rmap: fix BUG at rmap_walk

2013-12-18 Thread Andrew Morton
On Thu, 19 Dec 2013 08:16:35 +0800 Wanpeng Li wrote: > page_get_anon_vma() called in page_referenced_anon() will lock and > increase the refcount of anon_vma, page won't be locked for anonymous > page. This patch fix it by skip check anonymous page locked. > > [ 588.698828] kernel BUG at mm/r