Re: [PATCH] mm: change tlb_finish_mmu() to be more simple

2015-11-04 Thread yalin wang
> On Nov 4, 2015, at 16:36, Sergey Senozhatsky > wrote: > > On (11/04/15 15:35), yalin wang wrote: > [..] >> >> -for (batch = tlb->local.next; batch; batch = next) { >> -next = batch->next; >> +for (batch = tlb->local.next; batch; batch = batch->next) >>

Re: [PATCH] mm: change tlb_finish_mmu() to be more simple

2015-11-04 Thread Sergey Senozhatsky
On (11/04/15 15:35), yalin wang wrote: [..] > > - for (batch = tlb->local.next; batch; batch = next) { > - next = batch->next; > + for (batch = tlb->local.next; batch; batch = batch->next) > free_pages((unsigned long)batch, 0); accessing `batch->next' after

Re: [PATCH] mm: change tlb_finish_mmu() to be more simple

2015-11-04 Thread Kirill A. Shutemov
On Wed, Nov 04, 2015 at 03:35:31PM +0800, yalin wang wrote: > This patch remove unneeded *next temp variable, > make this function more simple to read. > > Signed-off-by: yalin wang > --- > mm/memory.c | 7 +++ > 1 file changed, 3 insertions(+), 4 deletions(-) > > diff --git a/mm/memory.c

Re: [PATCH] mm: change tlb_finish_mmu() to be more simple

2015-11-04 Thread Sergey Senozhatsky
On (11/04/15 15:35), yalin wang wrote: [..] > > - for (batch = tlb->local.next; batch; batch = next) { > - next = batch->next; > + for (batch = tlb->local.next; batch; batch = batch->next) > free_pages((unsigned long)batch, 0); accessing `batch->next' after

Re: [PATCH] mm: change tlb_finish_mmu() to be more simple

2015-11-04 Thread yalin wang
> On Nov 4, 2015, at 16:36, Sergey Senozhatsky > wrote: > > On (11/04/15 15:35), yalin wang wrote: > [..] >> >> -for (batch = tlb->local.next; batch; batch = next) { >> -next = batch->next; >> +for (batch = tlb->local.next; batch; batch =

Re: [PATCH] mm: change tlb_finish_mmu() to be more simple

2015-11-04 Thread Kirill A. Shutemov
On Wed, Nov 04, 2015 at 03:35:31PM +0800, yalin wang wrote: > This patch remove unneeded *next temp variable, > make this function more simple to read. > > Signed-off-by: yalin wang > --- > mm/memory.c | 7 +++ > 1 file changed, 3 insertions(+), 4 deletions(-) > >