Re: [PATCH] mm: fix pfn spans two sections in has_unmovable_pages()

2016-05-12 Thread Vlastimil Babka
On 05/12/2016 01:58 PM, Xishi Qiu wrote: On 2016/5/12 19:36, Vlastimil Babka wrote: On 05/09/2016 12:02 PM, Xishi Qiu wrote: Sounds ok, please try. Hi Vlastimil and Naoya, The mainline doesn't have this problem, because commit add05cecef80 ("mm: soft-offline: don't free target page in succ

Re: [PATCH] mm: fix pfn spans two sections in has_unmovable_pages()

2016-05-12 Thread Xishi Qiu
On 2016/5/12 19:36, Vlastimil Babka wrote: > On 05/09/2016 12:02 PM, Xishi Qiu wrote: >> On 2016/5/9 17:39, Vlastimil Babka wrote: >> >>> On 05/09/2016 10:34 AM, Xishi Qiu wrote: If the pfn is not aligned to pageblock, the check pfn may access a next pageblcok, and the next pageblock may

Re: [PATCH] mm: fix pfn spans two sections in has_unmovable_pages()

2016-05-12 Thread Vlastimil Babka
On 05/09/2016 12:02 PM, Xishi Qiu wrote: On 2016/5/9 17:39, Vlastimil Babka wrote: On 05/09/2016 10:34 AM, Xishi Qiu wrote: If the pfn is not aligned to pageblock, the check pfn may access a next pageblcok, and the next pageblock may belong to a next section. Because struct page has not been a

Re: [PATCH] mm: fix pfn spans two sections in has_unmovable_pages()

2016-05-12 Thread Naoya Horiguchi
On Mon, May 09, 2016 at 06:02:32PM +0800, Xishi Qiu wrote: > On 2016/5/9 17:39, Vlastimil Babka wrote: > > > On 05/09/2016 10:34 AM, Xishi Qiu wrote: > >> If the pfn is not aligned to pageblock, the check pfn may access a next > >> pageblcok, and the next pageblock may belong to a next section. Be

Re: [PATCH] mm: fix pfn spans two sections in has_unmovable_pages()

2016-05-09 Thread Xishi Qiu
On 2016/5/9 17:39, Vlastimil Babka wrote: > On 05/09/2016 10:34 AM, Xishi Qiu wrote: >> If the pfn is not aligned to pageblock, the check pfn may access a next >> pageblcok, and the next pageblock may belong to a next section. Because >> struct page has not been alloced in the next section, so ker

Re: [PATCH] mm: fix pfn spans two sections in has_unmovable_pages()

2016-05-09 Thread Vlastimil Babka
On 05/09/2016 10:34 AM, Xishi Qiu wrote: If the pfn is not aligned to pageblock, the check pfn may access a next pageblcok, and the next pageblock may belong to a next section. Because struct page has not been alloced in the next section, so kernel panic. I find the caller of has_unmovable_pages