Re: [PATCH] mm: hugepage: mark splitted page dirty when needed

2018-09-09 Thread Peter Xu
On Fri, Sep 07, 2018 at 01:54:35PM -0400, Jerome Glisse wrote: > On Fri, Sep 07, 2018 at 12:35:24PM +0800, Peter Xu wrote: > > On Thu, Sep 06, 2018 at 05:08:42PM +0300, Kirill A. Shutemov wrote: > > > On Thu, Sep 06, 2018 at 07:39:33PM +0800, Peter Xu wrote: > > > > On Wed, Sep 05, 2018 at 03:55:22

Re: [PATCH] mm: hugepage: mark splitted page dirty when needed

2018-09-07 Thread Jerome Glisse
On Fri, Sep 07, 2018 at 12:35:24PM +0800, Peter Xu wrote: > On Thu, Sep 06, 2018 at 05:08:42PM +0300, Kirill A. Shutemov wrote: > > On Thu, Sep 06, 2018 at 07:39:33PM +0800, Peter Xu wrote: > > > On Wed, Sep 05, 2018 at 03:55:22PM +0300, Kirill A. Shutemov wrote: > > > > On Wed, Sep 05, 2018 at 03:

Re: [PATCH] mm: hugepage: mark splitted page dirty when needed

2018-09-06 Thread Peter Xu
On Thu, Sep 06, 2018 at 05:08:42PM +0300, Kirill A. Shutemov wrote: > On Thu, Sep 06, 2018 at 07:39:33PM +0800, Peter Xu wrote: > > On Wed, Sep 05, 2018 at 03:55:22PM +0300, Kirill A. Shutemov wrote: > > > On Wed, Sep 05, 2018 at 03:30:37PM +0800, Peter Xu wrote: > > > > On Tue, Sep 04, 2018 at 10:

Re: [PATCH] mm: hugepage: mark splitted page dirty when needed

2018-09-06 Thread Jerome Glisse
On Thu, Sep 06, 2018 at 07:39:33PM +0800, Peter Xu wrote: > On Wed, Sep 05, 2018 at 03:55:22PM +0300, Kirill A. Shutemov wrote: > > On Wed, Sep 05, 2018 at 03:30:37PM +0800, Peter Xu wrote: > > > On Tue, Sep 04, 2018 at 10:00:28AM -0400, Zi Yan wrote: > > > > On 4 Sep 2018, at 4:01, Kirill A. Shute

Re: [PATCH] mm: hugepage: mark splitted page dirty when needed

2018-09-06 Thread Kirill A. Shutemov
On Thu, Sep 06, 2018 at 07:39:33PM +0800, Peter Xu wrote: > On Wed, Sep 05, 2018 at 03:55:22PM +0300, Kirill A. Shutemov wrote: > > On Wed, Sep 05, 2018 at 03:30:37PM +0800, Peter Xu wrote: > > > On Tue, Sep 04, 2018 at 10:00:28AM -0400, Zi Yan wrote: > > > > On 4 Sep 2018, at 4:01, Kirill A. Shute

Re: [PATCH] mm: hugepage: mark splitted page dirty when needed

2018-09-06 Thread Peter Xu
On Wed, Sep 05, 2018 at 08:49:20AM -0400, Zi Yan wrote: > On 5 Sep 2018, at 3:30, Peter Xu wrote: > > > On Tue, Sep 04, 2018 at 10:00:28AM -0400, Zi Yan wrote: > >> On 4 Sep 2018, at 4:01, Kirill A. Shutemov wrote: > >> > >>> On Tue, Sep 04, 2018 at 03:55:10PM +0800, Peter Xu wrote: > When sp

Re: [PATCH] mm: hugepage: mark splitted page dirty when needed

2018-09-06 Thread Peter Xu
On Wed, Sep 05, 2018 at 03:55:22PM +0300, Kirill A. Shutemov wrote: > On Wed, Sep 05, 2018 at 03:30:37PM +0800, Peter Xu wrote: > > On Tue, Sep 04, 2018 at 10:00:28AM -0400, Zi Yan wrote: > > > On 4 Sep 2018, at 4:01, Kirill A. Shutemov wrote: > > > > > > > On Tue, Sep 04, 2018 at 03:55:10PM +0800

Re: [PATCH] mm: hugepage: mark splitted page dirty when needed

2018-09-05 Thread Kirill A. Shutemov
On Wed, Sep 05, 2018 at 03:30:37PM +0800, Peter Xu wrote: > On Tue, Sep 04, 2018 at 10:00:28AM -0400, Zi Yan wrote: > > On 4 Sep 2018, at 4:01, Kirill A. Shutemov wrote: > > > > > On Tue, Sep 04, 2018 at 03:55:10PM +0800, Peter Xu wrote: > > >> When splitting a huge page, we should set all small p

Re: [PATCH] mm: hugepage: mark splitted page dirty when needed

2018-09-05 Thread Zi Yan
On 5 Sep 2018, at 3:30, Peter Xu wrote: > On Tue, Sep 04, 2018 at 10:00:28AM -0400, Zi Yan wrote: >> On 4 Sep 2018, at 4:01, Kirill A. Shutemov wrote: >> >>> On Tue, Sep 04, 2018 at 03:55:10PM +0800, Peter Xu wrote: When splitting a huge page, we should set all small pages as dirty if th

Re: [PATCH] mm: hugepage: mark splitted page dirty when needed

2018-09-05 Thread Peter Xu
On Tue, Sep 04, 2018 at 10:00:28AM -0400, Zi Yan wrote: > On 4 Sep 2018, at 4:01, Kirill A. Shutemov wrote: > > > On Tue, Sep 04, 2018 at 03:55:10PM +0800, Peter Xu wrote: > >> When splitting a huge page, we should set all small pages as dirty if > >> the original huge page has the dirty bit set b

Re: [PATCH] mm: hugepage: mark splitted page dirty when needed

2018-09-04 Thread Zi Yan
On 4 Sep 2018, at 4:01, Kirill A. Shutemov wrote: > On Tue, Sep 04, 2018 at 03:55:10PM +0800, Peter Xu wrote: >> When splitting a huge page, we should set all small pages as dirty if >> the original huge page has the dirty bit set before. Otherwise we'll >> lose the original dirty bit. > > We don

Re: [PATCH] mm: hugepage: mark splitted page dirty when needed

2018-09-04 Thread Kirill A. Shutemov
On Tue, Sep 04, 2018 at 03:55:10PM +0800, Peter Xu wrote: > When splitting a huge page, we should set all small pages as dirty if > the original huge page has the dirty bit set before. Otherwise we'll > lose the original dirty bit. We don't lose it. It got transfered to struct page flag: