Re: [PATCH] mm: simplify node/zone name printing

2016-12-19 Thread Michal Hocko
On Mon 19-12-16 11:27:59, Petr Mladek wrote: > On Mon 2016-12-19 09:12:10, Michal Hocko wrote: > > On Mon 19-12-16 16:32:28, Sergey Senozhatsky wrote: > > [...] > > > as far as I can tell, now for_each_populated_zone() iterations are > > > split by non-CONT printk() from show_zone_node(), which pre

Re: [PATCH] mm: simplify node/zone name printing

2016-12-19 Thread Michal Hocko
On Mon 19-12-16 11:05:49, Petr Mladek wrote: > On Mon 2016-12-19 08:00:47, Vlastimil Babka wrote: > > On 12/16/2016 01:32 PM, Michal Hocko wrote: > > > From: Michal Hocko > > > > > > show_node currently only prints Node id while it is always followed by > > > printing zone->name. As the node info

Re: [PATCH] mm: simplify node/zone name printing

2016-12-19 Thread Petr Mladek
On Mon 2016-12-19 09:12:10, Michal Hocko wrote: > On Mon 19-12-16 16:32:28, Sergey Senozhatsky wrote: > [...] > > as far as I can tell, now for_each_populated_zone() iterations are > > split by non-CONT printk() from show_zone_node(), which previously > > has been printk(KERN_CONT "%s: ", zone->n

Re: [PATCH] mm: simplify node/zone name printing

2016-12-19 Thread Petr Mladek
On Mon 2016-12-19 08:00:47, Vlastimil Babka wrote: > On 12/16/2016 01:32 PM, Michal Hocko wrote: > > From: Michal Hocko > > > > show_node currently only prints Node id while it is always followed by > > printing zone->name. As the node information is conditional to > > CONFIG_NUMA we have to be c

Re: [PATCH] mm: simplify node/zone name printing

2016-12-19 Thread Sergey Senozhatsky
On (12/19/16 09:12), Michal Hocko wrote: > On Mon 19-12-16 16:32:28, Sergey Senozhatsky wrote: > [...] > > as far as I can tell, now for_each_populated_zone() iterations are > > split by non-CONT printk() from show_zone_node(), which previously > > has been printk(KERN_CONT "%s: ", zone->name), s

Re: [PATCH] mm: simplify node/zone name printing

2016-12-19 Thread Michal Hocko
On Mon 19-12-16 16:32:28, Sergey Senozhatsky wrote: [...] > as far as I can tell, now for_each_populated_zone() iterations are > split by non-CONT printk() from show_zone_node(), which previously > has been printk(KERN_CONT "%s: ", zone->name), so pr_cont(\n) > between iterations was important, b

Re: [PATCH] mm: simplify node/zone name printing

2016-12-18 Thread Sergey Senozhatsky
Hello, On (12/19/16 08:00), Vlastimil Babka wrote: [..] > > @@ -4421,7 +4421,6 @@ void show_free_areas(unsigned int filter) > > printk("lowmem_reserve[]:"); > > for (i = 0; i < MAX_NR_ZONES; i++) > > printk(KERN_CONT " %ld", zone->lowmem_reserve[i]); > >

Re: [PATCH] mm: simplify node/zone name printing

2016-12-18 Thread Vlastimil Babka
On 12/16/2016 01:32 PM, Michal Hocko wrote: > From: Michal Hocko > > show_node currently only prints Node id while it is always followed by > printing zone->name. As the node information is conditional to > CONFIG_NUMA we have to be careful to always terminate the previous > continuation line bef