Re: [PATCH] mmap_region: cleanup, remove unneeded file != NULL check

2008-02-11 Thread Oleg Nesterov
Sorry for delay, On 02/06, Hugh Dickins wrote: > > On Sun, 3 Feb 2008, Oleg Nesterov wrote: > > > mmap_region() checks "file != NULL" when we know "file && vma_merge() == T". > > Also, swap these if/else branches, imho make the code a bit more readable. > > > > Signed-off-by: Oleg Nesterov <[EMA

Re: [PATCH] mmap_region: cleanup, remove unneeded file != NULL check

2008-02-06 Thread Hugh Dickins
On Sun, 3 Feb 2008, Oleg Nesterov wrote: > mmap_region() checks "file != NULL" when we know "file && vma_merge() == T". > Also, swap these if/else branches, imho make the code a bit more readable. > > Signed-off-by: Oleg Nesterov <[EMAIL PROTECTED]> Acked-with-a-but-by: Hugh Dickins <[EMAIL PROT