Re: [PATCH] mtd: require write permissions for locking and badblock ioctls

2021-03-28 Thread Miquel Raynal
On Wed, 2021-03-03 at 15:57:35 UTC, Michael Walle wrote: > MEMLOCK, MEMUNLOCK and OTPLOCK modify protection bits. Thus require > write permission. Depending on the hardware MEMLOCK might even be > write-once, e.g. for SPI-NOR flashes with their WP# tied to GND. OTPLOCK > is always write-once. > >

Re: [PATCH] mtd: require write permissions for locking and badblock ioctls

2021-03-22 Thread Richard Weinberger
- Ursprüngliche Mail - > Von: "Rafał Miłecki" > An: "Michael Walle" , "linux-mtd" > , "linux-kernel" > > CC: "Miquel Raynal" , "richard" , > "Vignesh Raghavendra" , > "Greg Kroah-Hartman&qu

Re: [PATCH] mtd: require write permissions for locking and badblock ioctls

2021-03-22 Thread Rafał Miłecki
On 03.03.2021 16:57, Michael Walle wrote: MEMLOCK, MEMUNLOCK and OTPLOCK modify protection bits. Thus require write permission. Depending on the hardware MEMLOCK might even be write-once, e.g. for SPI-NOR flashes with their WP# tied to GND. OTPLOCK is always write-once. MEMSETBADBLOCK modifies t

Re: [PATCH] mtd: require write permissions for locking and badblock ioctls

2021-03-03 Thread Richard Weinberger
- Ursprüngliche Mail - >>> Thanks for auditing the rest of these from my original patch. If this >>> is ok with userspace tools, it's fine with me, but I don't even have >>> this hardware to test with :) >> >> That's my fear. Michael, did you verify? > > I don't know any tools except the

Re: [PATCH] mtd: require write permissions for locking and badblock ioctls

2021-03-03 Thread Michael Walle
; Gesendet: Mittwoch, 3. März 2021 17:08:56 Betreff: Re: [PATCH] mtd: require write permissions for locking and badblock ioctls On Wed, Mar 03, 2021 at 04:57:35PM +0100, Michael Walle wrote: MEMLOCK, MEMUNLOCK and OTPLOCK modify protection bits. Thus require write permission. Depending on t

Re: [PATCH] mtd: require write permissions for locking and badblock ioctls

2021-03-03 Thread Richard Weinberger
Michael, - Ursprüngliche Mail - > Von: "Greg Kroah-Hartman" > An: "Michael Walle" > CC: "linux-mtd" , "linux-kernel" > , "Miquel Raynal" > , "richard" , "Vignesh > Raghavendra" > Gesendet

Re: [PATCH] mtd: require write permissions for locking and badblock ioctls

2021-03-03 Thread Greg Kroah-Hartman
On Wed, Mar 03, 2021 at 04:57:35PM +0100, Michael Walle wrote: > MEMLOCK, MEMUNLOCK and OTPLOCK modify protection bits. Thus require > write permission. Depending on the hardware MEMLOCK might even be > write-once, e.g. for SPI-NOR flashes with their WP# tied to GND. OTPLOCK > is always write-once.