Re: [PATCH] net/ncsi: fix checksum validation in response packet

2017-04-18 Thread Cédric Le Goater
On 04/18/2017 02:06 AM, Gavin Shan wrote: > On Mon, Apr 17, 2017 at 01:36:19PM -0400, David Miller wrote: >> From: Cédric Le Goater >> Date: Fri, 14 Apr 2017 10:56:37 +0200 >> >>> htonl was used instead of ntohl. Surely a typo. >>> >>> Signed-off-by: Cédric Le Goater >> >> I don't think so, "chec

Re: [PATCH] net/ncsi: fix checksum validation in response packet

2017-04-17 Thread Gavin Shan
On Mon, Apr 17, 2017 at 01:36:19PM -0400, David Miller wrote: >From: Cédric Le Goater >Date: Fri, 14 Apr 2017 10:56:37 +0200 > >> htonl was used instead of ntohl. Surely a typo. >> >> Signed-off-by: Cédric Le Goater > >I don't think so, "checksum" is of type "u32" thus is in host byte >order. T

Re: [PATCH] net/ncsi: fix checksum validation in response packet

2017-04-17 Thread David Miller
From: Cédric Le Goater Date: Fri, 14 Apr 2017 10:56:37 +0200 > htonl was used instead of ntohl. Surely a typo. > > Signed-off-by: Cédric Le Goater I don't think so, "checksum" is of type "u32" thus is in host byte order. Therefore "htonl()" is correct.