Re: [PATCH] net: eth: realtek: atp: checkpatch errors and warnings corrected

2014-11-04 Thread Roberto Medina
On 11/04/2014 11:19 AM, David Laight wrote: That code (and all the ones below) are gibberish, neither the old or new sequences make any sense. Thank you for your feedback I did it again and objdiff doesn't show any changes (if I'm not mistaken). Almost as though you used the wrong instruc

RE: [PATCH] net: eth: realtek: atp: checkpatch errors and warnings corrected

2014-11-04 Thread David Laight
From: Roberto Medina > On 11/03/2014 07:51 PM, Joe Perches wrote: > > > > Some ancient drivers could be regarded as neolithic > > curiosities that never need updating. This may be one. > > > > But if you really want to change it, could you please > > make sure that objdiff shows no changes? > > >

Re: [PATCH] net: eth: realtek: atp: checkpatch errors and warnings corrected

2014-11-03 Thread Roberto Medina
On 11/03/2014 07:51 PM, Joe Perches wrote: Some ancient drivers could be regarded as neolithic curiosities that never need updating. This may be one. But if you really want to change it, could you please make sure that objdiff shows no changes? I see some changes with objdiff, maybe this is

Re: [PATCH] net: eth: realtek: atp: checkpatch errors and warnings corrected

2014-11-03 Thread Joe Perches
On Mon, 2014-11-03 at 19:24 +0100, Roberto Medina wrote: > From: Roberto Medina > > Several warnings and errors corrected using checkpatch. > Some warnings like "line over 80" are still present. > > Before the patch: > total: 16 errors, 155 warnings, 38 checks, 883 lines checked > > With