Re: [PATCH] net: mediatek: Explicitly include pinctrl headers

2018-02-05 Thread Linus Walleij
On Mon, Feb 5, 2018 at 8:08 PM, Thierry Reding wrote: > On Mon, Feb 05, 2018 at 08:02:40PM +0100, Linus Walleij wrote: >> On Mon, Feb 5, 2018 at 6:59 PM, Thierry Reding >> wrote: >> >> > Anyway, I think going with the pinctrl/devinfo.h include only is fine >> > for now. If it turns out that the

Re: [PATCH] net: mediatek: Explicitly include pinctrl headers

2018-02-05 Thread Thierry Reding
On Mon, Feb 05, 2018 at 08:02:40PM +0100, Linus Walleij wrote: > On Mon, Feb 5, 2018 at 6:59 PM, Thierry Reding > wrote: > > > Anyway, I think going with the pinctrl/devinfo.h include only is fine > > for now. If it turns out that the Mediatek ethernet and Rockchip LVDS > > drivers can just omit

Re: [PATCH] net: mediatek: Explicitly include pinctrl headers

2018-02-05 Thread Linus Walleij
On Mon, Feb 5, 2018 at 6:59 PM, Thierry Reding wrote: > Anyway, I think going with the pinctrl/devinfo.h include only is fine > for now. If it turns out that the Mediatek ethernet and Rockchip LVDS > drivers can just omit the bits fiddling with struct dev_pin_info, we can > swap out the pinctrl/d

Re: [PATCH] net: mediatek: Explicitly include pinctrl headers

2018-02-05 Thread Thierry Reding
On Mon, Feb 05, 2018 at 09:42:21AM -0800, Linus Torvalds wrote: > On Mon, Feb 5, 2018 at 4:54 AM, Thierry Reding > wrote: > > > > Include these headers explicitly to avoid the build failure. > > I don't think you need to include *both*. > > used to include just . > > I'll edit your patches to

Re: [PATCH] net: mediatek: Explicitly include pinctrl headers

2018-02-05 Thread Linus Torvalds
On Mon, Feb 5, 2018 at 4:54 AM, Thierry Reding wrote: > > Include these headers explicitly to avoid the build failure. I don't think you need to include *both*. used to include just . I'll edit your patches to include just that. will come in automatically through it. Linus