On 6/20/25 10:37, Stefano Garzarella wrote:
>> -if (!new_transport || !try_module_get(new_transport->module))
>> -return -ENODEV;
>> +if (!new_transport || !try_module_get(new_transport->module)) {
>> +ret = -ENODEV;
>> +goto unlock;
>> +}
>> +
>
> I
On Wed, Jun 18, 2025 at 02:34:02PM +0200, Michal Luczaj wrote:
Transport assignment may race with module unload. Protect new_transport
from becoming a stale pointer.
This also takes care of an insecure call in vsock_use_local_transport();
add a lockdep assert.
BUG: unable to handle page fault f
On Thu, Feb 13, 2025 at 12:58:51PM +0100, Michal Luczaj wrote:
Commit 515745445e92 ("selftest/bpf: Add test for vsock removal from sockmap
on close()") added test that checked if proto::close() callback was invoked
on AF_VSOCK socket release. I.e. it verified that a close()d vsock does
indeed get
On Mon, Nov 04, 2024 at 04:57:05PM +0800, Philo Lu wrote:
> During virtnet_probe, default rss configuration is initialized, but was
> not committed to the device. This patch fix this by sending rss command
> after device ready in virtnet_probe. Otherwise, the actual rss
> configuration used by devi
On Mon, Oct 21, 2024 at 12:25:28PM +0200, Matthieu Baerts (NGI0) wrote:
> Listing all the values linked to the MPTCP sysctl knobs was not
> exercised in MPTCP test suite.
>
> Let's do that to avoid any regressions, but also to have a kernel with a
> debug kconfig verifying more assumptions. For th
On Tue, Feb 02, 2021 at 03:57:07PM +0100, Eric Dumazet wrote:
> On Tue, Feb 2, 2021 at 2:56 PM Leon Romanovsky wrote:
> >
> > From: Leon Romanovsky
> >
> > Fir the following compilation warnings:
> > 1031 | INDIRECT_CALLABLE_SCOPE void udp_v6_early_demux(struct sk_buff *skb)
> >
> > net/ipv6/ip6
On Tue, Feb 2, 2021 at 2:56 PM Leon Romanovsky wrote:
>
> From: Leon Romanovsky
>
> Fir the following compilation warnings:
> 1031 | INDIRECT_CALLABLE_SCOPE void udp_v6_early_demux(struct sk_buff *skb)
>
> net/ipv6/ip6_offload.c:182:41: warning: no previous prototype for
> ‘ipv6_gro_receive’ [-
On Mon, Feb 1, 2021 at 4:15 PM Alex Elder wrote:
>
> On 2/1/21 6:02 PM, Amy Parker wrote:
> > On Mon, Feb 1, 2021 at 3:32 PM Alex Elder wrote:
> >>
> >> When extracting the destination endpoint ID from the status in
> >> ipa_endpoint_status_skip(), u32_get_bits() is used. This happens to
> >> wo
On 2/1/21 6:02 PM, Amy Parker wrote:
On Mon, Feb 1, 2021 at 3:32 PM Alex Elder wrote:
When extracting the destination endpoint ID from the status in
ipa_endpoint_status_skip(), u32_get_bits() is used. This happens to
work, but it's wrong: the structure field is only 8 bits wide
instead of 32.
On Mon, Feb 1, 2021 at 4:02 PM Amy Parker wrote:
> > Fix this by using u8_get_bits() to get the destination endpoint ID.
>
> Isn't
>
Apologies about this - premature email sending. This was simply going
to be "Isn't endpoint_id u32?", which was addressed later anyways.
Best regards,
Amy Parker
On Mon, Feb 1, 2021 at 3:32 PM Alex Elder wrote:
>
> When extracting the destination endpoint ID from the status in
> ipa_endpoint_status_skip(), u32_get_bits() is used. This happens to
> work, but it's wrong: the structure field is only 8 bits wide
> instead of 32.
>
> Fix this by using u8_get_b
On 1/13/21 4:45 AM, Gilles DOFFE wrote:
> If 802.1q VLAN tag is removed from egress traffic, ingress
> traffic should by logic be tagged.
Which logic do you refer to? Software or hardware? What an user
configures with the "bridge vlan add ..." commands is the egress
tagging, but this also affects
On Wed, Jan 13, 2021 at 01:45:19PM +0100, Gilles DOFFE wrote:
> If 802.1q VLAN tag is removed from egress traffic, ingress
> traffic should by logic be tagged.
>
> Signed-off-by: Gilles DOFFE
> ---
> drivers/net/dsa/microchip/ksz8795.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/dr
Hi David/Richard
When you have time, can you take a look at this change? Thanks
Min
-Original Message-
From: min.li...@renesas.com
Sent: August 7, 2020 11:58 AM
To: richardcoch...@gmail.com
Cc: net...@vger.kernel.org; linux-kernel@vger.kernel.org; Min Li
Subject: [PATCH net 3/4] ptp:
On 2020/9/2 18:16, Eric Dumazet wrote:
>
>
> On 9/2/20 2:41 AM, Luo bin wrote:
>> When calling hinic_close in hinic_set_channels, netif_carrier_off
>> and netif_tx_disable are excuted, and TX host resources are freed
>> after that. Core may call hinic_xmit_frame to send pkt after
>> netif_tx_disa
On 2020/9/3 3:52, David Miller wrote:
> From: Luo bin
> Date: Wed, 2 Sep 2020 17:41:45 +0800
>
>> @@ -531,6 +531,11 @@ netdev_tx_t hinic_xmit_frame(struct sk_buff *skb,
>> struct net_device *netdev)
>> struct hinic_txq *txq;
>> struct hinic_qp *qp;
>>
>> +if (unlikely(!netif_carr
From: Luo bin
Date: Wed, 2 Sep 2020 17:41:45 +0800
> @@ -531,6 +531,11 @@ netdev_tx_t hinic_xmit_frame(struct sk_buff *skb, struct
> net_device *netdev)
> struct hinic_txq *txq;
> struct hinic_qp *qp;
>
> + if (unlikely(!netif_carrier_ok(netdev))) {
> + dev_kfree_sk
On 9/2/20 2:41 AM, Luo bin wrote:
> When calling hinic_close in hinic_set_channels, netif_carrier_off
> and netif_tx_disable are excuted, and TX host resources are freed
> after that. Core may call hinic_xmit_frame to send pkt after
> netif_tx_disable within a short time, so we should judge whet
On 7/16/2020 4:38 PM, Doug Berger wrote:
> The Hardware Filter Block RAM may not be preserved when the GENET
> block is reset during a deep sleep, so it is not sufficient to
> only backup and restore the enables.
>
> This commit clears out the HFB block and reprograms the rxnfc
> rules when the
On 6/24/2020 6:14 PM, Doug Berger wrote:
> When commit 474ea9cafc45 ("net: bcmgenet: correctly pad short
> packets") added the call to skb_padto() it should have been
> located before the nr_frags parameter was read since that value
> could be changed when padding packets with lengths between 55
On Fri, Jun 19, 2020 at 06:39:59PM +, Alexander Lobakin wrote:
> The ordering of netdev_features_strings[] makes no sense when it comes
> to user interaction, as list of features in `ethtool -k` input is sorted
> according to the corresponding bit's position.
> Instead, it *does* make sense whe
On 6/5/2020 7:01 AM, Dan Murphy wrote:
> When CONFIG_OF_MDIO is set to be a module the code block is not
> compiled. Use the IS_ENABLED macro that checks for both built in as
> well as module.
>
> Fixes: cf41a51db8985 ("of/phylib: Use device tree properties to initialize
> Marvell PHYs.")
> Si
On 10/16/2019 4:06 PM, Doug Berger wrote:
> It turns out that the "Workaround for putting the PHY in IDDQ mode"
> used by the internal EPHYs on 40nm Set-Top Box chips when powering
> down puts the interface to the GENET MAC in a state that can cause
> subsequent MAC resets to be incomplete.
>
>
On 2018/8/26 2:07, Andrew Lunn wrote:
This patch is a theoretical protect, and the problem does not really
happen.
I think you really get the point, do you think we need this patch?
I think it is not needed.
And if it was needed, it would indicate there is a bug somewhere else.
Hi, Andrew
On 2018年05月21日 22:59, Michael S. Tsirkin wrote:
On Mon, May 21, 2018 at 04:35:05PM +0800, Jason Wang wrote:
If we successfully linearize the packets, num_buf were set to zero
which was wrong since we now have only 1 buffer to be used for e.g in
the error path of receive_mergeable(). Zero num_b
On Mon, May 21, 2018 at 04:35:05PM +0800, Jason Wang wrote:
> If we successfully linearize the packets, num_buf were set to zero
> which was wrong since we now have only 1 buffer to be used for e.g in
> the error path of receive_mergeable(). Zero num_buf will lead the code
> try to pop the buffers
Hi agin,
On mer., avril 25 2018, Gregory CLEMENT wrote:
> Hi Maxime,
>
> On mer., avril 25 2018, Maxime Chevallier
> wrote:
>
>> The Marvell XSMI controller needs 3 clocks to operate correctly :
>> - The MG clock (clk 5)
>> - The MG Core clock (clk 6)
>> - The GOP clock (clk 18)
>>
>>
Hi Maxime,
On mer., avril 25 2018, Maxime Chevallier
wrote:
> The Marvell XSMI controller needs 3 clocks to operate correctly :
> - The MG clock (clk 5)
> - The MG Core clock (clk 6)
> - The GOP clock (clk 18)
>
> This commit adds them, to avoid system hangs when using these
> interfaces
On 03/02/2018 02:51 AM, David Laight wrote:
> From: Florian Fainelli
>>
>> Do not use memcpy() which is not safe, but instead use strncpy() which
>> will make sure that the string is NUL terminated (in the Linux
>> implementation) if the string is smaller than the length specified. This
>> fixes KA
From: Florian Fainelli
>
> Do not use memcpy() which is not safe, but instead use strncpy() which
> will make sure that the string is NUL terminated (in the Linux
> implementation) if the string is smaller than the length specified. This
> fixes KASAN out of bounds warnings while fetching port stat
From: Antoine Tenart
Date: Tue, 24 Oct 2017 11:41:28 +0200
> This patch replaces GFP_KERNEL by GFP_ATOMIC to avoid sleeping in the
> ndo_set_rx_mode() call which is called with BH disabled.
>
> Fixes: 3f518509dedc ("ethernet: Add new driver for Marvell Armada 375 network
> unit")
> Signed-off-b
From: Antoine Tenart
Date: Mon, 23 Oct 2017 15:24:31 +0200
> When Tx IRQs are used, txq_bufs_free() can be called from both the Tx
> path and from NAPI poll(). This led to CPU stalls as if these two tasks
> (Tx and Poll) are scheduled on two CPUs at the same time, DMA unmapping
> operations are d
From: Samuel Mendoza-Jonas
Date: Thu, 19 Oct 2017 13:43:07 +1100
> From: Gavin Shan
>
> When there are no NCSI channels probed, HWA (Hardware Arbitration)
> mode is enabled. It's not correct because HWA depends on the fact:
> NCSI channels exist and all of them support HWA mode. This disables
>
On 10/17/2017 07:55 AM, Daniel Borkmann wrote:
> PCPU_MIN_UNIT_SIZE is an implementation detail of the percpu
> allocator. Given we support __GFP_NOWARN now, lets just let
> the allocation request fail naturally instead. The two call
> sites from BPF mistakenly assumed __GFP_NOWARN would work, so
>
On Tue, Oct 17, 2017 at 04:55:54PM +0200, Daniel Borkmann wrote:
> PCPU_MIN_UNIT_SIZE is an implementation detail of the percpu
> allocator. Given we support __GFP_NOWARN now, lets just let
> the allocation request fail naturally instead. The two call
> sites from BPF mistakenly assumed __GFP_NOWAR
On Mon, 02 Oct 2017 05:15:32 -
Michael Witten wrote:
> On Sun, 1 Oct 2017 17:59:09 -0700, Stephen Hemminger wrote:
>
> > On Sun, 01 Oct 2017 22:19:20 - Michael Witten wrote:
> >
> >> + spin_lock_irqsave(&q->lock, flags);
> >> + skb = q->next;
> >> + __skb_queue_head_init(q);
> >> +
On Sun, 1 Oct 2017 17:59:09 -0700, Stephen Hemminger wrote:
> On Sun, 01 Oct 2017 22:19:20 - Michael Witten wrote:
>
>> +spin_lock_irqsave(&q->lock, flags);
>> +skb = q->next;
>> +__skb_queue_head_init(q);
>> +spin_unlock_irqrestore(&q->lock, flags);
>
> Other code manipulating
On Sun, 01 Oct 2017 22:19:20 -
Michael Witten wrote:
> + spin_lock_irqsave(&q->lock, flags);
> + skb = q->next;
> + __skb_queue_head_init(q);
> + spin_unlock_irqrestore(&q->lock, flags);
Other code manipulating lists uses splice operation and
a sk_buff_head temporary on the s
On 2016年12月23日 23:54, John Fastabend wrote:
On 16-12-23 06:37 AM, Jason Wang wrote:
We don't put page during linearizing, the would cause leaking when
xmit through XDP_TX or the packet exceeds PAGE_SIZE. Fix them by
put page accordingly. Also decrease the number of buffers during
linearizing t
On 16-12-23 06:37 AM, Jason Wang wrote:
> We don't put page during linearizing, the would cause leaking when
> xmit through XDP_TX or the packet exceeds PAGE_SIZE. Fix them by
> put page accordingly. Also decrease the number of buffers during
> linearizing to make sure caller can free buffers corre
On 12/16/2016 03:19 AM, Arnd Bergmann wrote:
The dependency is reversed: cpsw and netcp call into cpts,
but cpts depends on the other two in Kconfig. This can lead
to cpts being a loadable module and its callers built-in:
drivers/net/ethernet/ti/cpsw.o: In function `cpsw_remove':
cpsw.c:(.text
> -Original Message-
> From: Vitaly Kuznetsov [mailto:vkuzn...@redhat.com]
> Sent: Thursday, August 11, 2016 6:59 AM
> To: net...@vger.kernel.org
> Cc: de...@linuxdriverproject.org; linux-kernel@vger.kernel.org; Haiyang
> Zhang ; KY Srinivasan
> Subject: [PATCH net 3/4] hv_netvsc: protec
From: "Naveen N. Rao"
Date: Tue, 5 Apr 2016 15:32:55 +0530
> BPF_ALU32 and BPF_ALU64 tests for adding two 32-bit values that results in
> 32-bit overflow.
>
> Cc: Alexei Starovoitov
> Cc: Daniel Borkmann
> Cc: "David S. Miller"
> Cc: Ananth N Mavinakayanahalli
> Cc: Michael Ellerman
> Cc:
On 04/05/2016 12:02 PM, Naveen N. Rao wrote:
BPF_ALU32 and BPF_ALU64 tests for adding two 32-bit values that results in
32-bit overflow.
Cc: Alexei Starovoitov
Cc: Daniel Borkmann
Cc: "David S. Miller"
Cc: Ananth N Mavinakayanahalli
Cc: Michael Ellerman
Cc: Paul Mackerras
Signed-off-by: Na
On 4/5/16 3:02 AM, Naveen N. Rao wrote:
BPF_ALU32 and BPF_ALU64 tests for adding two 32-bit values that results in
32-bit overflow.
Cc: Alexei Starovoitov
Cc: Daniel Borkmann
Cc: "David S. Miller"
Cc: Ananth N Mavinakayanahalli
Cc: Michael Ellerman
Cc: Paul Mackerras
Signed-off-by: Naveen
On 2016/3/11 21:29, Sergei Shtylyov wrote:
Hello.
On 3/11/2016 4:53 AM, Daode Huang wrote:
In V2 chip, when sending mamagement packets, the driver should
config the port id to BD descs.
Signed-off-by: Daode Huang
Signed-off-by: Lisheng
---
drivers/net/ethernet/hisilicon/hns/hnae.h
From: Gregory CLEMENT
Date: Tue, 8 Mar 2016 13:57:06 +0100
> From: Dmitri Epshtein
>
> This commit corrects error printing when shutting down the port. Also
> magic numbers are replaced by existing macros.
>
> Signed-off-by: Dmitri Epshtein
> Signed-off-by: Gregory CLEMENT
Individual patch
Hello.
On 3/11/2016 4:53 AM, Daode Huang wrote:
In V2 chip, when sending mamagement packets, the driver should
config the port id to BD descs.
Signed-off-by: Daode Huang
Signed-off-by: Lisheng
---
drivers/net/ethernet/hisilicon/hns/hnae.h | 3 +++
drivers/net/ethernet/hisilicon/hn
On 2016/3/4 21:37, Sergei Shtylyov wrote:
Hello.
On 3/4/2016 4:09 AM, Daode Huang wrote:
In V2 chip, when sending mamagement packets, the driver should
config the port id to BD descs.
Signed-off-by: Daode Huang
Signed-off-by: Lisheng
---
drivers/net/ethernet/hisilicon/hns/hnae.h
Hello.
On 3/4/2016 4:09 AM, Daode Huang wrote:
In V2 chip, when sending mamagement packets, the driver should
config the port id to BD descs.
Signed-off-by: Daode Huang
Signed-off-by: Lisheng
---
drivers/net/ethernet/hisilicon/hns/hnae.h | 3 +++
drivers/net/ethernet/hisilicon/hns
Hello.
On 09/30/2015 01:39 AM, Joe Stringer wrote:
If ovs_fragment() was unable to fragment the skb due to an L2 header
that exceeds the supported length, skbs would be leaked. Fix the bug.
Fixes: 7f8a436 "openvswitch: Add conntrack action"
Signed-off-by: Joe Stringer
---
net/openvswitch/ac
On 29 September 2015 at 15:48, Rustad, Mark D wrote:
>> On Sep 29, 2015, at 3:39 PM, Joe Stringer wrote:
>>
>> @@ -728,8 +727,14 @@ static void ovs_fragment(struct vport *vport, struct
>> sk_buff *skb, u16 mru,
>> WARN_ONCE(1, "Failed fragment ->%s: eth=%04x, MRU=%d, MTU=%d.",
>>
> On Sep 29, 2015, at 3:39 PM, Joe Stringer wrote:
>
> @@ -728,8 +727,14 @@ static void ovs_fragment(struct vport *vport, struct
> sk_buff *skb, u16 mru,
> WARN_ONCE(1, "Failed fragment ->%s: eth=%04x, MRU=%d, MTU=%d.",
> ovs_vport_name(vport), ntohs(etherty
On 11/7/14, 2:35 PM, "Joe Stringer" wrote:
>Sure, I think fm10k_tx_encap_offload() is a good place for the header
>length
>check. Separately, my question above was regarding the idea of a helper
>for
>SKB_GSO_{GRE,UDP_TUNNEL}. The only reason it might be useful for the
>fm10k
>driver is becaus
On Friday, November 07, 2014 11:49:38 Vick, Matthew wrote:
> On 11/6/14, 9:05 PM, "Joe Stringer" wrote:
> >Let's merge both discussions into one thread (pick here or there). We
> >have
> >this suggestion or the one which simply checks for tunnels and
> >inner+outer
> >header lengths. Do you have a
On 11/6/14, 9:05 PM, "Joe Stringer" wrote:
>Let's merge both discussions into one thread (pick here or there). We
>have
>this suggestion or the one which simply checks for tunnels and
>inner+outer
>header lengths. Do you have a preference between them?
Agreed with merging the thread--consider
On Fri, 07 Nov 2014 14:07:36 Vick, Matthew wrote:
> On 11/6/14, 1:15 PM, "Joe Stringer" wrote:
> >Oh, I suppose we need to check the gso_type too. More like this?
> >
> >+static bool fm10k_gso_check(struct sk_buff *skb, struct net_device *dev)
> >+{
> >+ if ((skb_shinfo(skb)->gso_type & (SKB
On 11/6/14, 1:15 PM, "Joe Stringer" wrote:
>Oh, I suppose we need to check the gso_type too. More like this?
>
>+static bool fm10k_gso_check(struct sk_buff *skb, struct net_device *dev)
>+{
>+ if ((skb_shinfo(skb)->gso_type & (SKB_GSO_UDP_TUNNEL |
>SKB_GSO_GRE)) &&
>+ !fm10k_tx_en
On Thu, Nov 06, 2014 at 10:41:15AM -0800, Joe Stringer wrote:
> On Wed, Nov 05, 2014 at 06:54:00PM -0800, Alexander Duyck wrote:
> > On 11/04/2014 01:56 PM, Joe Stringer wrote:
> > > ndo_gso_check() was recently introduced to allow NICs to report the
> > > offloading support that they have on a per
On Wed, Nov 05, 2014 at 06:54:00PM -0800, Alexander Duyck wrote:
> On 11/04/2014 01:56 PM, Joe Stringer wrote:
> > ndo_gso_check() was recently introduced to allow NICs to report the
> > offloading support that they have on a per-skb basis. Add an
> > implementation for this driver which checks for
On 11/04/2014 01:56 PM, Joe Stringer wrote:
> ndo_gso_check() was recently introduced to allow NICs to report the
> offloading support that they have on a per-skb basis. Add an
> implementation for this driver which checks for something that looks
> like VXLAN.
>
> Implementation shamelessly stolen
On 18/07/14 16:25, Wei Liu wrote:
On Thu, Jul 17, 2014 at 08:09:51PM +0100, Zoltan Kiss wrote:
This patch makes this function aware that the first frag and the header might
share the same ring slot. That could happen if the first slot is bigger than
MAX_SKB_LEN. Due to this the error path might
On Thu, Jul 17, 2014 at 08:09:51PM +0100, Zoltan Kiss wrote:
> This patch makes this function aware that the first frag and the header might
> share the same ring slot. That could happen if the first slot is bigger than
> MAX_SKB_LEN. Due to this the error path might release that slot twice or
> n
linux-kernel@vger.kernel.org;
>> de...@linuxdriverproject.org; o...@aepfle.de; a...@canonical.com;
>> jasow...@redhat.com
>> Subject: Re: [PATCH net 3/3] Drivers: net: hyperv: Address UDP checksum
>> issues
>>
>> From: KY Srinivasan
>> Date: Wed, 9 Apr 2014 18:08:47 +
; jasow...@redhat.com
> Subject: Re: [PATCH net 3/3] Drivers: net: hyperv: Address UDP checksum
> issues
>
> From: KY Srinivasan
> Date: Wed, 9 Apr 2014 18:08:47 +
>
> > Thanks Dave. I will COW the SKB before changing the checksum value. I
> > do have a question thoug
From: KY Srinivasan
Date: Wed, 9 Apr 2014 18:08:47 +
> Thanks Dave. I will COW the SKB before changing the checksum
> value. I do have a question though. I looked at a bunch of hardware
> drivers and they modify the header information, specially checksum
> field and I could not see where the
; jasow...@redhat.com
> Subject: Re: [PATCH net 3/3] Drivers: net: hyperv: Address UDP checksum
> issues
>
> From: "K. Y. Srinivasan"
> Date: Tue, 8 Apr 2014 12:46:11 -0700
>
> > } else if (net_trans_info & INFO_UDP) {
> > - csum_info->trans
From: "K. Y. Srinivasan"
Date: Tue, 8 Apr 2014 12:46:11 -0700
> } else if (net_trans_info & INFO_UDP) {
> - csum_info->transmit.udp_checksum = 1;
> + /* UDP checksum offload is not supported on ws2008r2.
> + * Furthermore, on ws2012 and ws2012r2, there
On 09/13/2013 07:37 PM, Andre Naujoks wrote:
> The old implementation was heavy on str* functions and sprintf calls.
> This version is more manual, but faster.
>
> Profiling just the printing of a 3 char CAN-id resulted in 60 instructions
> for the manual method and over 2000 for the sprintf metho
On 13.09.2013 19:37, Andre Naujoks wrote:
> The old implementation was heavy on str* functions and sprintf calls.
> This version is more manual, but faster.
>
> Profiling just the printing of a 3 char CAN-id resulted in 60 instructions
> for the manual method and over 2000 for the sprintf method.
r.kernel.org;
> de...@linuxdriverproject.org
> Subject: Re: [PATCH net, 3/3] hyperv: Fix page buffer handling in
> rndis_filter_send_request()
>
> On Mon, Oct 01, 2012 at 03:30:57PM -0700, Haiyang Zhang wrote:
> > Add another page buffer if the request message crossed page boundary.
> >
>
>
On Mon, Oct 01, 2012 at 03:30:57PM -0700, Haiyang Zhang wrote:
> Add another page buffer if the request message crossed page boundary.
>
What are the user visible effects of this bug fix? Please put that
in the commit message.
regards,
dan carpenter
--
To unsubscribe from this list: send the l
On Wed, 30 May 2001 12:53:36 +0200 (MET DST),
Andrzej Krzysztofowicz <[EMAIL PROTECTED]> wrote:
>When __init for modules will be implemented ?
When I can persuade myself that discarding code pages but retaining the
associated exception tables and any arch dependent data for the
discarded module
> David Woodhouse wrote:
> >
> > [EMAIL PROTECTED] said:
> > > -#ifdef CONFIG_ISAPNP
> > > +#if defined(CONFIG_ISAPNP) || (defined(CONFIG_ISAPNP_MODULE) && defined(MODULE))
> >
> > The result here would be a 3c509 module which differs depending on whether
> > the ISAPNP module happened to be com
"Paul Gortmaker wrote:"
> Andrzej Krzysztofowicz wrote:
> >
> > The following patch fixes some ISA PnP #ifdefs (enable modular,
> > disable when non-available) for 3c509 and smc-ultra.
>
> > -#ifdef CONFIG_ISAPNP
> > +#if defined(CONFIG_ISAPNP) || (defined(CONFIG_ISAPNP_MODULE) && defined(MODULE
David Woodhouse wrote:
>
> [EMAIL PROTECTED] said:
> > -#ifdef CONFIG_ISAPNP
> > +#if defined(CONFIG_ISAPNP) || (defined(CONFIG_ISAPNP_MODULE) && defined(MODULE))
>
> The result here would be a 3c509 module which differs depending on whether
> the ISAPNP module happened to be compiled at the sam
"David Woodhouse wrote:"
>
> [EMAIL PROTECTED] said:
> > -#ifdef CONFIG_ISAPNP
> > +#if defined(CONFIG_ISAPNP) || (defined(CONFIG_ISAPNP_MODULE) && defined(MODULE))
>
> The result here would be a 3c509 module which differs depending on whether
> the ISAPNP module happened to be compiled at th
Andrzej Krzysztofowicz wrote:
>
> The following patch fixes some ISA PnP #ifdefs (enable modular,
> disable when non-available) for 3c509 and smc-ultra.
> -#ifdef CONFIG_ISAPNP
> +#if defined(CONFIG_ISAPNP) || (defined(CONFIG_ISAPNP_MODULE) && defined(MODULE))
Hrrm. AFAICT the token CONFIG_ISA
78 matches
Mail list logo
