Re: [PATCH] nfds: Fix NFSD_MDS_PR_KEY on 32-bit by adding ULL postfix

2016-06-06 Thread J. Bruce Fields
On Sun, Jun 05, 2016 at 06:21:43AM -0400, Jeff Layton wrote: > On Sun, 2016-06-05 at 11:23 +0200, Geert Uytterhoeven wrote: > > On 32-bit: > > > > fs/nfsd/blocklayout.c: In function ‘nfsd4_block_get_device_info_scsi’: > > fs/nfsd/blocklayout.c:337: warning: integer constant is too large fo

Re: [PATCH] nfds: Fix NFSD_MDS_PR_KEY on 32-bit by adding ULL postfix

2016-06-05 Thread Jeff Layton
On Sun, 2016-06-05 at 11:23 +0200, Geert Uytterhoeven wrote: > On 32-bit: > > fs/nfsd/blocklayout.c: In function ‘nfsd4_block_get_device_info_scsi’: > fs/nfsd/blocklayout.c:337: warning: integer constant is too large for > ‘long’ type > fs/nfsd/blocklayout.c:344: warning: integer cons

Re: [PATCH] nfds: Fix NFSD_MDS_PR_KEY on 32-bit by adding ULL postfix

2016-03-28 Thread J. Bruce Fields
On Fri, Mar 25, 2016 at 07:04:22PM +0100, Christoph Hellwig wrote: > Looks fine, thanks! > > Reviewed-by: Christoph Hellwig Thanks, applying for 4.6.--b.

Re: [PATCH] nfds: Fix NFSD_MDS_PR_KEY on 32-bit by adding ULL postfix

2016-03-25 Thread Joe Perches
On Fri, 2016-03-25 at 19:04 +0100, Christoph Hellwig wrote: > Reviewed-by: Christoph Hellwig Outside of the known 64 bit only uses, this shows a few oddities too: $ git grep -P -w -i '0x[0-9a-f]{9,16}(?!ull|ll)'

Re: [PATCH] nfds: Fix NFSD_MDS_PR_KEY on 32-bit by adding ULL postfix

2016-03-25 Thread Christoph Hellwig
Looks fine, thanks! Reviewed-by: Christoph Hellwig