Re: [PATCH] of: fix device compatibility scoring

2016-05-06 Thread Reza Arbab
On Thu, May 05, 2016 at 02:47:18PM -0500, Rob Herring wrote: This matching is very sensitive to changes. Can you please describe what conditions don't work for you and add a test case for that condition to the unit test. Ah, thanks for pointing out the unit test. Looking at the test cases ther

Re: [PATCH] of: fix device compatibility scoring

2016-05-05 Thread Rob Herring
On Thu, May 5, 2016 at 1:30 PM, Reza Arbab wrote: > If a constraint given to __of_device_is_compatible() does not > match, we should just move to the next constraint without adding > to the compatibility score. Instead, the function immediately > returns 0. > > Do not return from __of_device_is_co