Re: [PATCH] of: overlay: fix memory leak of ovcs on error exit path

2017-12-04 Thread Geert Uytterhoeven
Hi Dan, On Thu, Nov 30, 2017 at 1:50 PM, Dan Carpenter wrote: > On Thu, Nov 30, 2017 at 07:14:45AM -0500, Frank Rowand wrote: >> On 11/29/17 14:17, Colin King wrote: >> > From: Colin Ian King >> > >> > Currently if the call to of_resolve_phandles fails then then ovcs >> > is not kfree'd on the e

Re: [PATCH] of: overlay: fix memory leak of ovcs on error exit path

2017-11-30 Thread Rob Herring
On Thu, Nov 30, 2017 at 9:01 AM, Frank Rowand wrote: > On 11/30/17 08:37, Frank Rowand wrote: >> Hi Colin, Rob, >> >> On 11/30/17 07:18, Colin Ian King wrote: >>> On 30/11/17 12:14, Frank Rowand wrote: On 11/29/17 14:17, Colin King wrote: > From: Colin Ian King > > Currently if t

Re: [PATCH] of: overlay: fix memory leak of ovcs on error exit path

2017-11-30 Thread Frank Rowand
On 11/30/17 08:37, Frank Rowand wrote: > Hi Colin, Rob, > > On 11/30/17 07:18, Colin Ian King wrote: >> On 30/11/17 12:14, Frank Rowand wrote: >>> On 11/29/17 14:17, Colin King wrote: From: Colin Ian King Currently if the call to of_resolve_phandles fails then then ovcs is not

Re: [PATCH] of: overlay: fix memory leak of ovcs on error exit path

2017-11-30 Thread Geert Uytterhoeven
Hi Dan, On Thu, Nov 30, 2017 at 1:50 PM, Dan Carpenter wrote: > On Thu, Nov 30, 2017 at 07:14:45AM -0500, Frank Rowand wrote: >> On 11/29/17 14:17, Colin King wrote: >> > From: Colin Ian King >> > >> > Currently if the call to of_resolve_phandles fails then then ovcs >> > is not kfree'd on the e

Re: [PATCH] of: overlay: fix memory leak of ovcs on error exit path

2017-11-30 Thread Frank Rowand
Hi Colin, Rob, On 11/30/17 07:18, Colin Ian King wrote: > On 30/11/17 12:14, Frank Rowand wrote: >> On 11/29/17 14:17, Colin King wrote: >>> From: Colin Ian King >>> >>> Currently if the call to of_resolve_phandles fails then then ovcs >>> is not kfree'd on the error exit path. Rather than try a

Re: [PATCH] of: overlay: fix memory leak of ovcs on error exit path

2017-11-30 Thread Colin Ian King
On 30/11/17 12:50, Dan Carpenter wrote: > On Thu, Nov 30, 2017 at 07:14:45AM -0500, Frank Rowand wrote: >> On 11/29/17 14:17, Colin King wrote: >>> From: Colin Ian King >>> >>> Currently if the call to of_resolve_phandles fails then then ovcs >>> is not kfree'd on the error exit path. Rather than

Re: [PATCH] of: overlay: fix memory leak of ovcs on error exit path

2017-11-30 Thread Dan Carpenter
On Thu, Nov 30, 2017 at 07:14:45AM -0500, Frank Rowand wrote: > On 11/29/17 14:17, Colin King wrote: > > From: Colin Ian King > > > > Currently if the call to of_resolve_phandles fails then then ovcs > > is not kfree'd on the error exit path. Rather than try and make > > the clean up exit path m

Re: [PATCH] of: overlay: fix memory leak of ovcs on error exit path

2017-11-30 Thread Colin Ian King
On 30/11/17 12:14, Frank Rowand wrote: > On 11/29/17 14:17, Colin King wrote: >> From: Colin Ian King >> >> Currently if the call to of_resolve_phandles fails then then ovcs >> is not kfree'd on the error exit path. Rather than try and make >> the clean up exit path more convoluted, fix this by j

Re: [PATCH] of: overlay: fix memory leak of ovcs on error exit path

2017-11-30 Thread Frank Rowand
On 11/29/17 14:17, Colin King wrote: > From: Colin Ian King > > Currently if the call to of_resolve_phandles fails then then ovcs > is not kfree'd on the error exit path. Rather than try and make > the clean up exit path more convoluted, fix this by just kfree'ing > ovcs at the point of error de