Re: [PATCH] omap3isp: add support for CSI1 bus

2017-03-02 Thread Pavel Machek
Hi! > > >> + > > >> +static int isp_of_parse_node_endpoint(struct device *dev, > > >> + struct device_node *node, > > >> + struct isp_async_subdev *isd) > > >> +{ > > >> +struct isp_bus_cfg *buscfg; > > >> +s

Re: [PATCH] omap3isp: add support for CSI1 bus

2017-02-19 Thread Laurent Pinchart
Hi Pavel, On Wednesday 15 Feb 2017 10:42:29 Pavel Machek wrote: > Hi! > > >> diff --git a/drivers/media/platform/omap3isp/isp.c > >> b/drivers/media/platform/omap3isp/isp.c index 0321d84..88bc7c6 100644 > >> --- a/drivers/media/platform/omap3isp/isp.c > >> +++ b/drivers/media/platform/omap3isp/is

Re: [PATCH] omap3isp: add support for CSI1 bus

2017-02-15 Thread Pavel Machek
On Wed 2017-02-15 17:57:46, Sebastian Reichel wrote: > Hi, > > On Wed, Feb 15, 2017 at 11:23:01AM +0100, Pavel Machek wrote: > > It seems csiphy_routing_cfg_3430 is not called at all. I added > > printks, but they don't trigger. If you have an idea what is going on > > there, it would help... > >

Re: [PATCH] omap3isp: add support for CSI1 bus

2017-02-15 Thread Sebastian Reichel
Hi, On Wed, Feb 15, 2017 at 11:23:01AM +0100, Pavel Machek wrote: > It seems csiphy_routing_cfg_3430 is not called at all. I added > printks, but they don't trigger. If you have an idea what is going on > there, it would help... You added printk to csiphy_routing_cfg_3630 instead of csiphy_routin

Re: [PATCH] omap3isp: add support for CSI1 bus

2017-02-15 Thread Pavel Machek
Hi! > > + if (enable) { > > + csirxfe = OMAP343X_CONTROL_CSIRXFE_PWRDNZ | > > + OMAP343X_CONTROL_CSIRXFE_RESET; > > + > > + if (buscfg->phy_layer) > > + csirxfe |= OMAP343X_CONTROL_CSIRXFE_SELFORM;

Re: [PATCH] omap3isp: add support for CSI1 bus

2017-02-15 Thread Pavel Machek
Hi! > > diff --git a/drivers/media/platform/omap3isp/isp.c > > b/drivers/media/platform/omap3isp/isp.c index 0321d84..88bc7c6 100644 > > --- a/drivers/media/platform/omap3isp/isp.c > > +++ b/drivers/media/platform/omap3isp/isp.c > > @@ -2024,21 +2024,92 @@ enum isp_of_phy { > > ISP_OF_PHY_CSIP

Re: [PATCH] omap3isp: add support for CSI1 bus

2017-02-08 Thread Laurent Pinchart
Hi Pavel, Thank you for the patch. On Wednesday 08 Feb 2017 13:57:38 Pavel Machek wrote: > Obtain the CSI1/CCP2 bus parameters from the OF node. > > ISP CSI1 module needs all the bits correctly set to work. > > OMAP3430 needs various syscon CONTROL_CSIRXFE bits set in order to > operate. Implem

Re: [PATCH] omap3isp: add support for CSI1 bus

2017-02-08 Thread kbuild test robot
Hi Pavel, [auto build test WARNING on v4.9-rc8] [cannot apply to linuxtv-media/master next-20170208] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/commits/Pavel-Machek/omap3isp-add-support-for-CSI1-bus