Re: [PATCH] oom_reaper: switch to struct list_head for reap queue

2017-02-20 Thread Michal Hocko
On Wed 15-02-17 20:01:33, Aleksa Sarai wrote: > > > > This is an extra pointer to task_struct and more lines of code to > > > > accomplish the same thing. Why would we want to do that? > > > > > > I don't think it's more "actual" lines of code (I think the wrapping is > > > inflating the line numb

Re: [PATCH] oom_reaper: switch to struct list_head for reap queue

2017-02-15 Thread Aleksa Sarai
This is an extra pointer to task_struct and more lines of code to accomplish the same thing. Why would we want to do that? I don't think it's more "actual" lines of code (I think the wrapping is inflating the line number count), I too think it doesn't make sense to blow task_struct and the gen

Re: [PATCH] oom_reaper: switch to struct list_head for reap queue

2017-02-15 Thread Ingo Molnar
* Aleksa Sarai wrote: > >>Rather than implementing an open addressing linked list structure > >>ourselves, use the standard list_head structure to improve consistency > >>with the rest of the kernel and reduce confusion. > >> > >>Cc: Michal Hocko > >>Cc: Oleg Nesterov > >>Signed-off-by: Aleksa

Re: [PATCH] oom_reaper: switch to struct list_head for reap queue

2017-02-14 Thread Oleg Nesterov
On 02/15, Aleksa Sarai wrote: > > >This is an extra pointer to task_struct and more lines of code to > >accomplish the same thing. Why would we want to do that? > > I don't think it's more "actual" lines of code (I think the wrapping is > inflating the line number count), I too think it doesn't ma

Re: [PATCH] oom_reaper: switch to struct list_head for reap queue

2017-02-14 Thread Aleksa Sarai
Rather than implementing an open addressing linked list structure ourselves, use the standard list_head structure to improve consistency with the rest of the kernel and reduce confusion. Cc: Michal Hocko Cc: Oleg Nesterov Signed-off-by: Aleksa Sarai --- include/linux/sched.h | 6 +- kern

Re: [PATCH] oom_reaper: switch to struct list_head for reap queue

2017-02-14 Thread Johannes Weiner
On Wed, Feb 15, 2017 at 02:07:14AM +1100, Aleksa Sarai wrote: > Rather than implementing an open addressing linked list structure > ourselves, use the standard list_head structure to improve consistency > with the rest of the kernel and reduce confusion. > > Cc: Michal Hocko > Cc: Oleg Nesterov