Re: [PATCH] percpu: drop useless macro PER_CPU_DEF_ATTRIBUTES

2017-03-29 Thread Cao jin
On 03/29/2017 11:28 PM, Tejun Heo wrote: > On Wed, Mar 29, 2017 at 10:38:17AM +0800, Cao jin wrote: >> On 03/29/2017 12:00 AM, Tejun Heo wrote: >>> On Tue, Mar 28, 2017 at 04:35:07PM +0800, Cao jin wrote: Signed-off-by: Cao jin >>> >>> I'm not sure. I think I used it during development and

Re: [PATCH] percpu: drop useless macro PER_CPU_DEF_ATTRIBUTES

2017-03-29 Thread Tejun Heo
On Wed, Mar 29, 2017 at 10:38:17AM +0800, Cao jin wrote: > On 03/29/2017 12:00 AM, Tejun Heo wrote: > > On Tue, Mar 28, 2017 at 04:35:07PM +0800, Cao jin wrote: > >> Signed-off-by: Cao jin > > > > I'm not sure. I think I used it during development and it's not like > > it costs anything to keep.

Re: [PATCH] percpu: drop useless macro PER_CPU_DEF_ATTRIBUTES

2017-03-28 Thread Cao jin
On 03/29/2017 12:00 AM, Tejun Heo wrote: > On Tue, Mar 28, 2017 at 04:35:07PM +0800, Cao jin wrote: >> Signed-off-by: Cao jin > > I'm not sure. I think I used it during development and it's not like > it costs anything to keep. > It easily confusing newbies without any comments for its purpo

Re: [PATCH] percpu: drop useless macro PER_CPU_DEF_ATTRIBUTES

2017-03-28 Thread Tejun Heo
On Tue, Mar 28, 2017 at 04:35:07PM +0800, Cao jin wrote: > Signed-off-by: Cao jin I'm not sure. I think I used it during development and it's not like it costs anything to keep. Thanks. -- tejun