Re: [PATCH] perf list: Fix --raw-dump argument

2014-04-10 Thread Ramkumar Ramachandra
Jiri Olsa wrote: > but looks like the usage is for bash completion only, so we probably > need only the first example functionality above. > > If this is the case I think it should not be an option but another > command like 'raw-dump'. I decided that there's no point making it an option, so I've

Re: [PATCH] perf list: Fix --raw-dump argument

2014-04-09 Thread Jiri Olsa
On Thu, Mar 27, 2014 at 05:27:41PM -0400, Ramkumar Ramachandra wrote: > While adding usage information, 44d742e (perf list: Add usage, > 2013-10-30) broke > > $ perf list --raw-dump > > Fix this by making raw-dump a proper argument. > > Cc: David Ahern > Cc: Jiri Olsa > Cc: Arnaldo Carvalho

Re: [PATCH] perf list: fix --raw-dump

2013-12-29 Thread Dongsheng Yang
On 12/29/2013 05:11 AM, Ramkumar Ramachandra wrote: Arnaldo Carvalho de Melo wrote: So is the patch below the one to apply? When these things happen, it helps if you resubmit with a v2 in the subject line and then an explicit Ack is provided, be it from, in this case, David, or Ramkumar could ju

Re: [PATCH] perf list: fix --raw-dump

2013-12-29 Thread Ramkumar Ramachandra
Arnaldo Carvalho de Melo wrote: > So is the patch below the one to apply? When these things happen, it > helps if you resubmit with a v2 in the subject line and then an explicit > Ack is provided, be it from, in this case, David, or Ramkumar could just > add it since David provided it in free form,

Re: [PATCH] perf list: fix --raw-dump

2013-12-16 Thread Arnaldo Carvalho de Melo
Em Thu, Dec 12, 2013 at 01:04:04PM +0530, Ramkumar Ramachandra escreveu: > David Ahern wrote: > > Why not make raw_dump a proper argument? > > Sure, that'd work too. I was thinking of a minimal way to fix the > problem myself. So is the patch below the one to apply? When these things happen, it h

Re: [PATCH] perf list: fix --raw-dump

2013-12-15 Thread Dongsheng Yang
On 12/12/2013 02:34 AM, Ramkumar Ramachandra wrote: David Ahern wrote: Why not make raw_dump a proper argument? Sure, that'd work too. I was thinking of a minimal way to fix the problem myself. Hi Ramkumar and David, If this argument is only used for perf complement, how about make it hi

Re: [PATCH] perf list: fix --raw-dump

2013-12-12 Thread David Ahern
On 12/12/13, 12:34 AM, Ramkumar Ramachandra wrote: David Ahern wrote: Why not make raw_dump a proper argument? Sure, that'd work too. I was thinking of a minimal way to fix the problem myself. diff --git a/tools/perf/builtin-list.c b/tools/perf/builtin-list.c index 011195e38f21..b553d0c4ca82

Re: [PATCH] perf list: fix --raw-dump

2013-12-11 Thread Ramkumar Ramachandra
David Ahern wrote: > Why not make raw_dump a proper argument? Sure, that'd work too. I was thinking of a minimal way to fix the problem myself. > diff --git a/tools/perf/builtin-list.c b/tools/perf/builtin-list.c > index 011195e38f21..b553d0c4ca82 100644 > --- a/tools/perf/builtin-list.c > +++ b/

Re: [PATCH] perf list: fix --raw-dump

2013-12-11 Thread David Ahern
On 12/11/13, 3:16 AM, Ramkumar Ramachandra wrote: While adding usage information, 44d742e (perf list: Add usage, 2013-10-30) broke $ perf list --raw-dump by asking parse_options() to stop at non-option (PARSE_OPT_STOP_AT_NON_OPTION), hence parsing the option --raw-dump and barfing. Ask it to