Re: [PATCH] perf report: Add option to collapse undesired parts of call graph

2013-07-01 Thread Greg Price
On Thu, Jun 27, 2013 at 01:58:16PM +0900, Namhyung Kim wrote: > On Wed, 26 Jun 2013 18:25:01 -0400, Greg Price wrote: > > On Wed, Jun 26, 2013 at 10:28:56AM +0900, Namhyung Kim wrote: > >> On Sat, 22 Jun 2013 23:17:20 -0400, Greg Price wrote: > >> > @@ -1211,8 +1214,13 @@ static int > >> > machine

Re: [PATCH] perf report: Add option to collapse undesired parts of call graph

2013-06-26 Thread Namhyung Kim
On Wed, 26 Jun 2013 18:25:01 -0400, Greg Price wrote: > Hi Namhyung, > > Thanks for the detailed review! > > > On Wed, Jun 26, 2013 at 10:28:56AM +0900, Namhyung Kim wrote: >> On Sat, 22 Jun 2013 23:17:20 -0400, Greg Price wrote: >> > For example, in an application with an expensive function >> > i

Re: [PATCH] perf report: Add option to collapse undesired parts of call graph

2013-06-26 Thread Greg Price
Hi Namhyung, hi Ingo, On Tue, Jun 25, 2013 at 05:01:47PM +0900, Namhyung Kim wrote: > >>TBH I'm not really familiar with the GTK front-end, as I mainly use > >>the TUI. At a quick trial, it looks like --blackbox has the expected > >>effect on the display there; though with or without --blackbox I

Re: [PATCH] perf report: Add option to collapse undesired parts of call graph

2013-06-26 Thread Greg Price
Hi Namhyung, Thanks for the detailed review! On Wed, Jun 26, 2013 at 10:28:56AM +0900, Namhyung Kim wrote: > On Sat, 22 Jun 2013 23:17:20 -0400, Greg Price wrote: > > For example, in an application with an expensive function > > implemented with deeply nested recursive calls, the default > > cal

Re: [PATCH] perf report: Add option to collapse undesired parts of call graph

2013-06-25 Thread Namhyung Kim
Hi Greg, On Sat, 22 Jun 2013 23:17:20 -0400, Greg Price wrote: > For example, in an application with an expensive function > implemented with deeply nested recursive calls, the default > call-graph presentation is dominated by the different callchains > within that function. By treating the funct

Re: [PATCH] perf report: Add option to collapse undesired parts of call graph

2013-06-25 Thread Namhyung Kim
Hi, 2013-06-25 PM 4:47, Ingo Molnar wrote: * Greg Price wrote: It would also be nice if all these visualization variants were available in the GTK front-end. TBH I'm not really familiar with the GTK front-end, as I mainly use the TUI. At a quick trial, it looks like --blackbox has the exp

Re: [PATCH] perf report: Add option to collapse undesired parts of call graph

2013-06-25 Thread Ingo Molnar
* Greg Price wrote: > > It would also be nice if all these visualization variants were available > > in the GTK front-end. > > TBH I'm not really familiar with the GTK front-end, as I mainly use > the TUI. At a quick trial, it looks like --blackbox has the expected > effect on the display the

Re: [PATCH] perf report: Add option to collapse undesired parts of call graph

2013-06-24 Thread Greg Price
On Mon, Jun 24, 2013 at 10:32:53AM +0200, Ingo Molnar wrote: > * Jiri Olsa wrote: > > It could also make sense to allow sorting on this > > the same way as we do for '-s parent' and report only > > '[other]' and 'blackbox' entries. > > > > Also I dont like the 'blackbox' option name, it should >

Re: [PATCH] perf report: Add option to collapse undesired parts of call graph

2013-06-24 Thread Greg Price
On Sun, Jun 23, 2013 at 11:53:27PM +0200, Jiri Olsa wrote: > Seems useful, sort of oposite to parent option (-p) Cool, good to hear. > Any reason why not add this for top? Only because I didn't think about it. :) Seems like a good idea; I'll add that. > > diff --git a/tools/perf/util/machine

Re: [PATCH] perf report: Add option to collapse undesired parts of call graph

2013-06-24 Thread Ingo Molnar
* Jiri Olsa wrote: > It could also make sense to allow sorting on this > the same way as we do for '-s parent' and report only > '[other]' and 'blackbox' entries. > > Also I dont like the 'blackbox' option name, it should > complement the parent option somehow.. but no idea ;-) Looks like a ni

Re: [PATCH] perf report: Add option to collapse undesired parts of call graph

2013-06-23 Thread Jiri Olsa
On Sat, Jun 22, 2013 at 11:17:20PM -0400, Greg Price wrote: > For example, in an application with an expensive function > implemented with deeply nested recursive calls, the default > call-graph presentation is dominated by the different callchains > within that function. By treating the function

Re: [PATCH] perf report: Add option to collapse undesired parts of call graph

2013-06-22 Thread Greg Price
For example, in an application with an expensive function implemented with deeply nested recursive calls, the default call-graph presentation is dominated by the different callchains within that function. By treating the function as a black box, we can collect the callchains leading into the funct

Re: [PATCH] perf report: Add option to collapse undesired parts of call graph

2013-02-24 Thread Greg Price
On Fri, Jan 11, 2013 at 02:27:36AM -0300, Arnaldo Carvalho de Melo wrote: > Em Fri, Dec 07, 2012 at 02:30:44AM -0500, Greg Price escreveu: > > If an application has an expensive function implemented with a large > > tree of calls to helper functions, the default call-graph presentation > > will be

Re: [PATCH] perf report: Add option to collapse undesired parts of call graph

2013-01-11 Thread Arnaldo Carvalho de Melo
Em Fri, Dec 07, 2012 at 02:30:44AM -0500, Greg Price escreveu: > If an application has an expensive function implemented with a large > tree of calls to helper functions, the default call-graph presentation > will be dominated by the many different call-chains within that > function. By treating t