Re: [PATCH] perf script python: Fix dict reference counting

2018-07-09 Thread Jiri Olsa
On Mon, Jul 09, 2018 at 12:25:33PM +0300, Janne Huttunen wrote: > On Sun, 2018-07-08 at 13:17 +0200, Jiri Olsa wrote: > > On Fri, Jul 06, 2018 at 09:53:44AM +0300, Janne Huttunen wrote: > > > > > > The dictionaries are attached to the parameter tuple that steals the > > > references. The code shou

Re: [PATCH] perf script python: Fix dict reference counting

2018-07-09 Thread Janne Huttunen
On Sun, 2018-07-08 at 13:17 +0200, Jiri Olsa wrote: > On Fri, Jul 06, 2018 at 09:53:44AM +0300, Janne Huttunen wrote: > > > > The dictionaries are attached to the parameter tuple that steals the > > references. The code should not decrement the reference counters > > explicitly. Otherwise the obje

Re: [PATCH] perf script python: Fix dict reference counting

2018-07-08 Thread Jiri Olsa
On Fri, Jul 06, 2018 at 09:53:44AM +0300, Janne Huttunen wrote: > The dictionaries are attached to the parameter tuple that steals the > references. The code should not decrement the reference counters > explicitly. Otherwise the objects might be released while they are > still in use which may cau