Re: [PATCH] perf stat: Do not show stats if workload fails

2014-01-02 Thread Arnaldo Carvalho de Melo
Em Thu, Dec 26, 2013 at 09:11:22AM -0500, David Ahern escreveu: > On 12/24/13, 8:30 AM, Arnaldo Carvalho de Melo wrote: > >Em Tue, Dec 24, 2013 at 09:53:42AM -0300, Arnaldo Carvalho de Melo escreveu: > >>>The thing to check is perf_evlist__{prepare,start}_workload notification > >>>errors using SIG

Re: [PATCH] perf stat: Do not show stats if workload fails

2013-12-26 Thread Arnaldo Carvalho de Melo
Em Thu, Dec 26, 2013 at 09:18:17AM -0500, David Ahern escreveu: > On 12/26/13, 9:15 AM, Arnaldo Carvalho de Melo wrote: > >Right, but I can't apply that patch, as it makes 'perf stat > >whatever-workload' to fail, as I realized when doing a demo to someone > >interested in using perf ;-\ > > > >So

Re: [PATCH] perf stat: Do not show stats if workload fails

2013-12-26 Thread Arnaldo Carvalho de Melo
Em Thu, Dec 26, 2013 at 09:18:17AM -0500, David Ahern escreveu: > On 12/26/13, 9:15 AM, Arnaldo Carvalho de Melo wrote: > >Right, but I can't apply that patch, as it makes 'perf stat > >whatever-workload' to fail, as I realized when doing a demo to someone > >interested in using perf ;-\ > > > >So

Re: [PATCH] perf stat: Do not show stats if workload fails

2013-12-26 Thread David Ahern
On 12/26/13, 9:15 AM, Arnaldo Carvalho de Melo wrote: Right, but I can't apply that patch, as it makes 'perf stat whatever-workload' to fail, as I realized when doing a demo to someone interested in using perf ;-\ So for now I'm not applying that one. right, so you want one with < 0 check or w

Re: [PATCH] perf stat: Do not show stats if workload fails

2013-12-26 Thread Arnaldo Carvalho de Melo
Em Thu, Dec 26, 2013 at 09:11:22AM -0500, David Ahern escreveu: > On 12/24/13, 8:30 AM, Arnaldo Carvalho de Melo wrote: > >Em Tue, Dec 24, 2013 at 09:53:42AM -0300, Arnaldo Carvalho de Melo escreveu: > >>>The thing to check is perf_evlist__{prepare,start}_workload notification > >>>errors using SIG

Re: [PATCH] perf stat: Do not show stats if workload fails

2013-12-26 Thread David Ahern
On 12/24/13, 8:30 AM, Arnaldo Carvalho de Melo wrote: Em Tue, Dec 24, 2013 at 09:53:42AM -0300, Arnaldo Carvalho de Melo escreveu: >The thing to check is perf_evlist__{prepare,start}_workload notification >errors using SIGUSR1, that we need to check for in the caller, and emit >the message, no?

Re: [PATCH] perf stat: Do not show stats if workload fails

2013-12-24 Thread Arnaldo Carvalho de Melo
Em Tue, Dec 24, 2013 at 09:53:42AM -0300, Arnaldo Carvalho de Melo escreveu: > The thing to check is perf_evlist__{prepare,start}_workload notification > errors using SIGUSR1, that we need to check for in the caller, and emit > the message, no? Something like this: 1. We tell perf_evlist__prepare

Re: [PATCH] perf stat: Do not show stats if workload fails

2013-12-24 Thread Arnaldo Carvalho de Melo
Em Mon, Dec 23, 2013 at 07:29:54PM -0500, David Ahern escreveu: > On 12/23/13, 2:37 PM, Arnaldo Carvalho de Melo wrote: > >int perf_evlist__start_workload(struct perf_evlist *evlist) > >{ > > if (evlist->workload.cork_fd > 0) { > > char bf = 0; > > /* Remove

Re: [PATCH] perf stat: Do not show stats if workload fails

2013-12-23 Thread David Ahern
On 12/23/13, 2:37 PM, Arnaldo Carvalho de Melo wrote: int perf_evlist__start_workload(struct perf_evlist *evlist) { if (evlist->workload.cork_fd > 0) { char bf = 0; int ret; /* * Remove the cork, let it rip!

Re: [PATCH] perf stat: Do not show stats if workload fails

2013-12-23 Thread Arnaldo Carvalho de Melo
Em Fri, Dec 20, 2013 at 08:57:59AM +0100, Ingo Molnar escreveu: > * David Ahern wrote: > > > Currently perf-stat attempts to show counter stats even if the workload > > is bogus: > > > > $ perf stat -- foo > > foo: No such file or directory > > > > Performance counter stats for 'foo': > > > >

Re: [PATCH] perf stat: Do not show stats if workload fails

2013-12-19 Thread Ingo Molnar
* David Ahern wrote: > Currently perf-stat attempts to show counter stats even if the workload > is bogus: > > $ perf stat -- foo > foo: No such file or directory > > Performance counter stats for 'foo': > >task-clock >context-switches >cpu-migrations >