Re: [PATCH] perf timechart: remove lock_depth from trace_entry

2013-11-26 Thread Arnaldo Carvalho de Melo
Em Tue, Nov 26, 2013 at 05:47:55PM +0400, Stanislav Fomichev escreveu: > > Se above, if before this patch the format_field info was obtained from > > the perf.data file, why should it now get it from the local machine? > Yes, sorry for confusion, I didn't know that we can obtain trace events > for

Re: [PATCH] perf timechart: remove lock_depth from trace_entry

2013-11-26 Thread Stanislav Fomichev
> Se above, if before this patch the format_field info was obtained from > the perf.data file, why should it now get it from the local machine? Yes, sorry for confusion, I didn't know that we can obtain trace events format from the perf.data. I hence have no concerns regarding your implementation :

Re: [PATCH] perf timechart: remove lock_depth from trace_entry

2013-11-26 Thread Arnaldo Carvalho de Melo
Em Tue, Nov 26, 2013 at 03:05:36PM +0400, Stanislav Fomichev escreveu: > > This makes the new tool stop processing old files, can you try the patch > > attached instead? > I see two downsides to your approach: Huh? > 1) with your patch I'm now required to run 'perf timechart record' and > 'perf

Re: [PATCH] perf timechart: remove lock_depth from trace_entry

2013-11-26 Thread Stanislav Fomichev
> This makes the new tool stop processing old files, can you try the patch > attached instead? I see two downsides to your approach: 1) with your patch I'm now required to run 'perf timechart record' and 'perf timechart' on the same machine (otherwise, on the 'perf timechart' machine we may have wr

Re: [PATCH] perf timechart: remove lock_depth from trace_entry

2013-11-25 Thread Arnaldo Carvalho de Melo
Em Tue, Oct 22, 2013 at 02:32:23PM +0400, Stanislav Fomichev escreveu: > On Mon, Oct 07, 2013 at 02:48:34PM +0800, Chia-I Wu wrote: > > struct trace_entry went out-of-sync with the kernel since > > > > commit b000c8065 "tracing: Remove the extra 4 bytes of padding in events" > > > > causing "per

Re: [PATCH] perf timechart: remove lock_depth from trace_entry

2013-10-22 Thread Stanislav Fomichev
On Mon, Oct 07, 2013 at 02:48:34PM +0800, Chia-I Wu wrote: > struct trace_entry went out-of-sync with the kernel since > > commit b000c8065 "tracing: Remove the extra 4 bytes of padding in events" > > causing "perf timechart" to be broken. > > Signed-off-by: Chia-I Wu Reviewed-by: Stanislav Fo