Re: [PATCH] pinctrl: msm: Pass along set_wake failures

2018-07-12 Thread Lina Iyer
On Thu, Jul 12 2018 at 10:31 -0600, Evan Green wrote: On Tue, Jul 10, 2018 at 1:38 PM Lina Iyer wrote: On Tue, Jul 10 2018 at 12:53 -0600, Evan Green wrote: >On Mon, Jul 9, 2018 at 10:27 AM Bjorn Andersson > wrote: >Our understanding is the downstream kernel had an interrupt hierarchy >of GIC

Re: [PATCH] pinctrl: msm: Pass along set_wake failures

2018-07-12 Thread Evan Green
On Tue, Jul 10, 2018 at 1:38 PM Lina Iyer wrote: > > On Tue, Jul 10 2018 at 12:53 -0600, Evan Green wrote: > >On Mon, Jul 9, 2018 at 10:27 AM Bjorn Andersson > > wrote: > >> > >> Sorry for not getting back to you in a timely manner Evan, I wanted to > >> read up more on the details of how this is

Re: [PATCH] pinctrl: msm: Pass along set_wake failures

2018-07-10 Thread Lina Iyer
On Tue, Jul 10 2018 at 12:53 -0600, Evan Green wrote: On Mon, Jul 9, 2018 at 10:27 AM Bjorn Andersson wrote: Sorry for not getting back to you in a timely manner Evan, I wanted to read up more on the details of how this is supposed to work. I still haven't done so, but here's my concern: When

Re: [PATCH] pinctrl: msm: Pass along set_wake failures

2018-07-10 Thread Evan Green
On Mon, Jul 9, 2018 at 10:27 AM Bjorn Andersson wrote: > > Sorry for not getting back to you in a timely manner Evan, I wanted to > read up more on the details of how this is supposed to work. I still > haven't done so, but here's my concern: > > When we power down the SoC we're no longer powering

Re: [PATCH] pinctrl: msm: Pass along set_wake failures

2018-07-09 Thread Bjorn Andersson
On Tue 19 Jun 16:43 PDT 2018, Evan Green wrote: > The MSM pinctrl driver quietly swallows errors that occur > when trying to call .irq_set_wake. It should instead pass > those failures up the chain so the caller can react to them. > Swallowing the error for instance causes gpio_keys to think that

Re: [PATCH] pinctrl: msm: Pass along set_wake failures

2018-06-29 Thread Linus Walleij
On Wed, Jun 20, 2018 at 1:45 AM Evan Green wrote: > The MSM pinctrl driver quietly swallows errors that occur > when trying to call .irq_set_wake. It should instead pass > those failures up the chain so the caller can react to them. > Swallowing the error for instance causes gpio_keys to think th