Re: [PATCH] power: supply: max77693_charger: fix unintentional fall-through

2018-08-04 Thread Gustavo A. R. Silva
Hi Sebastian, On 07/22/2018 05:17 PM, Sebastian Reichel wrote: > Hi, > > On Wed, Jul 18, 2018 at 08:14:50AM +0200, Krzysztof Kozlowski wrote: >> On 17 July 2018 at 23:47, Gustavo A. R. Silva wrote: >>> It seems that a *break* is missing in order to avoid a fall-through. >>> Otherwise, the calcul

Re: [PATCH] power: supply: max77693_charger: fix unintentional fall-through

2018-07-22 Thread Sebastian Reichel
Hi, On Wed, Jul 18, 2018 at 08:14:50AM +0200, Krzysztof Kozlowski wrote: > On 17 July 2018 at 23:47, Gustavo A. R. Silva wrote: > > It seems that a *break* is missing in order to avoid a fall-through. > > Otherwise, the calculation of *data* makes no sense. > > > > Addresses-Coverity-ID: 1271172

Re: [PATCH] power: supply: max77693_charger: fix unintentional fall-through

2018-07-19 Thread Gustavo A. R. Silva
Hi Krzysztof, On 07/18/2018 01:14 AM, Krzysztof Kozlowski wrote: > On 17 July 2018 at 23:47, Gustavo A. R. Silva wrote: >> It seems that a *break* is missing in order to avoid a fall-through. >> Otherwise, the calculation of *data* makes no sense. >> >> Addresses-Coverity-ID: 1271172 ("Missing br

Re: [PATCH] power: supply: max77693_charger: fix unintentional fall-through

2018-07-17 Thread Krzysztof Kozlowski
On 17 July 2018 at 23:47, Gustavo A. R. Silva wrote: > It seems that a *break* is missing in order to avoid a fall-through. > Otherwise, the calculation of *data* makes no sense. > > Addresses-Coverity-ID: 1271172 ("Missing break in switch") > Fixes: 87c2d9067893 ("power: max77693: Add charger dri