Re: [PATCH] print kdump kernel loaded status in stack dump

2018-01-26 Thread Dave Young
On 01/26/18 at 01:17pm, Petr Mladek wrote: > On Fri 2018-01-26 15:37:24, Dave Young wrote: > > On 01/19/18 at 12:47pm, Dave Young wrote: > > > On 01/18/18 at 01:57pm, Steven Rostedt wrote: > > > > On Thu, 18 Jan 2018 10:02:17 -0800 > > > > Andi Kleen wrote: > > > > > > > > > Dave Young writes: >

Re: [PATCH] print kdump kernel loaded status in stack dump

2018-01-26 Thread Petr Mladek
On Fri 2018-01-26 15:37:24, Dave Young wrote: > On 01/19/18 at 12:47pm, Dave Young wrote: > > On 01/18/18 at 01:57pm, Steven Rostedt wrote: > > > On Thu, 18 Jan 2018 10:02:17 -0800 > > > Andi Kleen wrote: > > > > > > > Dave Young writes: > > > > > printk("%sHardware name: %s\n", >

Re: [PATCH] print kdump kernel loaded status in stack dump

2018-01-25 Thread Dave Young
On 01/19/18 at 12:47pm, Dave Young wrote: > On 01/18/18 at 01:57pm, Steven Rostedt wrote: > > On Thu, 18 Jan 2018 10:02:17 -0800 > > Andi Kleen wrote: > > > > > Dave Young writes: > > > > printk("%sHardware name: %s\n", > > > >log_lvl, dump_stack_arch_desc

Re: [PATCH] print kdump kernel loaded status in stack dump

2018-01-19 Thread Andi Kleen
On Fri, Jan 19, 2018 at 02:45:38PM +0900, Sergey Senozhatsky wrote: > On (01/18/18 10:02), Andi Kleen wrote: > > Dave Young writes: > > > printk("%sHardware name: %s\n", > > > log_lvl, dump_stack_arch_desc_str); > > > + if (kexec_crash_loaded()) > > > + printk("%

Re: [PATCH] print kdump kernel loaded status in stack dump

2018-01-19 Thread Sergey Senozhatsky
On (01/19/18 16:42), Dave Young wrote: [..] > > [I'm not entirely sure I see why do we have printk_delay() in > >vprintk_emit()... I mean I probably can see some reasoning behind > >it, but at the same it makes sense to slow down console_unlock() > >as well] > > Looks like I am the guy

Re: [PATCH] print kdump kernel loaded status in stack dump

2018-01-19 Thread Dave Young
On 01/19/18 at 05:28pm, Sergey Senozhatsky wrote: > On (01/19/18 16:16), Dave Young wrote: > > On 01/19/18 at 02:45pm, Sergey Senozhatsky wrote: > > > On (01/18/18 10:02), Andi Kleen wrote: > > > > Dave Young writes: > > > > > printk("%sHardware name: %s\n", > > > > >

Re: [PATCH] print kdump kernel loaded status in stack dump

2018-01-19 Thread Sergey Senozhatsky
On (01/19/18 16:16), Dave Young wrote: > I thought about adding an option to improve printk_delay so it can > delay every n lines, eg. 25 rows. Maybe that idea works for this > issue? /* sent the message too soon */ printk_delay() has no effect there. it limits only printk()->vprintk_emit() and w

Re: [PATCH] print kdump kernel loaded status in stack dump

2018-01-19 Thread Sergey Senozhatsky
On (01/19/18 16:16), Dave Young wrote: > On 01/19/18 at 02:45pm, Sergey Senozhatsky wrote: > > On (01/18/18 10:02), Andi Kleen wrote: > > > Dave Young writes: > > > > printk("%sHardware name: %s\n", > > > >log_lvl, dump_stack_arch_desc_str); > > > > +

Re: [PATCH] print kdump kernel loaded status in stack dump

2018-01-19 Thread Dave Young
On 01/19/18 at 02:45pm, Sergey Senozhatsky wrote: > On (01/18/18 10:02), Andi Kleen wrote: > > Dave Young writes: > > > printk("%sHardware name: %s\n", > > > log_lvl, dump_stack_arch_desc_str); > > > + if (kexec_crash_loaded()) > > > + printk("%skdump kernel load

Re: [PATCH] print kdump kernel loaded status in stack dump

2018-01-18 Thread Sergey Senozhatsky
On (01/18/18 10:02), Andi Kleen wrote: > Dave Young writes: > > printk("%sHardware name: %s\n", > >log_lvl, dump_stack_arch_desc_str); > > + if (kexec_crash_loaded()) > > + printk("%skdump kernel loaded\n", log_lvl); > > Oops/warnings are getting longer

Re: [PATCH] print kdump kernel loaded status in stack dump

2018-01-18 Thread Dave Young
On 01/18/18 at 01:57pm, Steven Rostedt wrote: > On Thu, 18 Jan 2018 10:02:17 -0800 > Andi Kleen wrote: > > > Dave Young writes: > > > printk("%sHardware name: %s\n", > > > log_lvl, dump_stack_arch_desc_str); > > > + if (kexec_crash_loaded()) > > > + printk("%sk

Re: [PATCH] print kdump kernel loaded status in stack dump

2018-01-18 Thread Steven Rostedt
On Thu, 18 Jan 2018 10:02:17 -0800 Andi Kleen wrote: > Dave Young writes: > > printk("%sHardware name: %s\n", > >log_lvl, dump_stack_arch_desc_str); > > + if (kexec_crash_loaded()) > > + printk("%skdump kernel loaded\n", log_lvl); > > Oops/warnings

Re: [PATCH] print kdump kernel loaded status in stack dump

2018-01-18 Thread Andi Kleen
Dave Young writes: > printk("%sHardware name: %s\n", > log_lvl, dump_stack_arch_desc_str); > + if (kexec_crash_loaded()) > + printk("%skdump kernel loaded\n", log_lvl); Oops/warnings are getting longer and longer, often scrolling away from the sc

Re: [PATCH] print kdump kernel loaded status in stack dump

2018-01-17 Thread Dave Young
On 01/17/18 at 02:42pm, Petr Mladek wrote: > On Wed 2018-01-17 20:32:44, Dave Young wrote: > > Hi, > > > > Thanks for your comments. > > On 01/17/18 at 09:57am, Petr Mladek wrote: > > > On Wed 2018-01-17 12:50:57, Dave Young wrote: > > > > It is useful to print kdump kernel loaded status in dump_s

Re: [PATCH] print kdump kernel loaded status in stack dump

2018-01-17 Thread Steven Rostedt
On Wed, 17 Jan 2018 14:42:17 +0100 Petr Mladek wrote: > > kexec_crash_loaded is enough, we only care if kdump kernel being > > loaded or not, nothing else, no matter how long it has been loaded. > > In Fedora/RHEL a kdump service takes care of loading the kernel but > > it runs after networking i

Re: [PATCH] print kdump kernel loaded status in stack dump

2018-01-17 Thread Petr Mladek
On Wed 2018-01-17 20:32:44, Dave Young wrote: > Hi, > > Thanks for your comments. > On 01/17/18 at 09:57am, Petr Mladek wrote: > > On Wed 2018-01-17 12:50:57, Dave Young wrote: > > > It is useful to print kdump kernel loaded status in dump_stack() > > > especially when panic happens so that we ca

Re: [PATCH] print kdump kernel loaded status in stack dump

2018-01-17 Thread Dave Young
Hi, Thanks for your comments. On 01/17/18 at 09:57am, Petr Mladek wrote: > On Wed 2018-01-17 12:50:57, Dave Young wrote: > > It is useful to print kdump kernel loaded status in dump_stack() > > especially when panic happens so that we can differenciate > > kdump kernel early hang and a normal p

Re: [PATCH] print kdump kernel loaded status in stack dump

2018-01-17 Thread Petr Mladek
On Wed 2018-01-17 12:50:57, Dave Young wrote: > It is useful to print kdump kernel loaded status in dump_stack() > especially when panic happens so that we can differenciate > kdump kernel early hang and a normal panic in a bug report. > > Signed-off-by: Dave Young > --- > kernel/printk/printk