Re: [PATCH] printk: Print cpu number along with time

2014-09-10 Thread Andrew Morton
On Tue, 9 Sep 2014 13:16:58 -0400 J__rn Engel wrote: > On Wed, 4 June 2014 19:15:06 -0400, J__rn Engel wrote: > > On Mon, 28 April 2014 17:22:19 -0700, Andrew Morton wrote: > > > On Mon, 28 Apr 2014 19:40:39 -0400 J__rn Engel wrote: > > > > On Thu, 24 April 2014 15:40:24 -0400, J__rn Engel wrote

Re: [PATCH] printk: Print cpu number along with time

2014-09-09 Thread Jörn Engel
On Wed, 4 June 2014 19:15:06 -0400, Jörn Engel wrote: > On Mon, 28 April 2014 17:22:19 -0700, Andrew Morton wrote: > > On Mon, 28 Apr 2014 19:40:39 -0400 J__rn Engel wrote: > > > On Thu, 24 April 2014 15:40:24 -0400, J__rn Engel wrote: > > > > On Wed, 23 April 2014 20:52:47 -0400, J__rn Engel wrot

Re: [PATCH] printk: Print cpu number along with time

2014-06-04 Thread Jörn Engel
On Wed, 4 June 2014 16:28:32 -0700, Andrew Morton wrote: > > Sorry, it seems I'm better at losing stuff than I thought I was. The trouble with forgetting stuff is that few people remember ever doing so. But they do remember other people forgetting stuff. > I've restored the patch to the input q

Re: [PATCH] printk: Print cpu number along with time

2014-06-04 Thread Andrew Morton
On Wed, 4 Jun 2014 19:15:06 -0400 J__rn Engel wrote: > On Mon, 28 April 2014 17:22:19 -0700, Andrew Morton wrote: > > On Mon, 28 Apr 2014 19:40:39 -0400 J__rn Engel wrote: > > > On Thu, 24 April 2014 15:40:24 -0400, J__rn Engel wrote: > > > > On Wed, 23 April 2014 20:52:47 -0400, J__rn Engel wro

Re: [PATCH] printk: Print cpu number along with time

2014-06-04 Thread Jörn Engel
On Mon, 28 April 2014 17:22:19 -0700, Andrew Morton wrote: > On Mon, 28 Apr 2014 19:40:39 -0400 J__rn Engel wrote: > > On Thu, 24 April 2014 15:40:24 -0400, J__rn Engel wrote: > > > On Wed, 23 April 2014 20:52:47 -0400, J__rn Engel wrote: > > > > > > > > I use the patch below for some time now.

Re: [PATCH] printk: Print cpu number along with time

2014-04-28 Thread Andrew Morton
On Mon, 28 Apr 2014 19:40:39 -0400 J__rn Engel wrote: > On Thu, 24 April 2014 15:40:24 -0400, J__rn Engel wrote: > > On Wed, 23 April 2014 20:52:47 -0400, J__rn Engel wrote: > > > > > > I use the patch below for some time now. While it doesn't avoid the > > > log pollution in the first place, i

Re: [PATCH] printk: Print cpu number along with time

2014-04-28 Thread Jörn Engel
On Thu, 24 April 2014 15:40:24 -0400, Jörn Engel wrote: > On Wed, 23 April 2014 20:52:47 -0400, Jörn Engel wrote: > > > > I use the patch below for some time now. While it doesn't avoid the > > log pollution in the first place, it lessens the impact somewhat. > > Added a config option and ported

Re: [PATCH] printk: Print cpu number along with time

2014-04-24 Thread Jörn Engel
On Fri, 25 April 2014 00:21:20 +0200, Jiri Kosina wrote: > On Thu, 24 Apr 2014, David Rientjes wrote: > > > > Well, if you have dmesg dump from panic that happens every other year, > > > and > > > you have to do post-mortem analysis on it, I am pretty sure you would > > > love > > > to be able

Re: [PATCH] printk: Print cpu number along with time

2014-04-24 Thread Jiri Kosina
On Thu, 24 Apr 2014, David Rientjes wrote: > > Well, if you have dmesg dump from panic that happens every other year, and > > you have to do post-mortem analysis on it, I am pretty sure you would love > > to be able to figure out how the stack traces would look like without > > inter-CPU interl

Re: [PATCH] printk: Print cpu number along with time

2014-04-24 Thread David Rientjes
On Fri, 25 Apr 2014, Jiri Kosina wrote: > > > +#ifdef CONFIG_PRINTK_CPU > > > + if (!buf) > > > + return snprintf(NULL, 0, "[%5lu.00,%02x] ", > > > > %02x for a cpu? What happens on machines with 8k cpus? > > Ummm ... what issue do you see here, Greg? It'll print 0x1f40, no? > I t

Re: [PATCH] printk: Print cpu number along with time

2014-04-24 Thread Greg Kroah-Hartman
On Fri, Apr 25, 2014 at 12:12:06AM +0200, Jiri Kosina wrote: > On Thu, 24 Apr 2014, Greg Kroah-Hartman wrote: > > > > +#ifdef CONFIG_PRINTK_CPU > > > + if (!buf) > > > + return snprintf(NULL, 0, "[%5lu.00,%02x] ", > > > > %02x for a cpu? What happens on machines with 8k cpus? > > Um

Re: [PATCH] printk: Print cpu number along with time

2014-04-24 Thread Jiri Kosina
On Thu, 24 Apr 2014, Greg Kroah-Hartman wrote: > > +#ifdef CONFIG_PRINTK_CPU > > + if (!buf) > > + return snprintf(NULL, 0, "[%5lu.00,%02x] ", > > %02x for a cpu? What happens on machines with 8k cpus? Ummm ... what issue do you see here, Greg? It'll print 0x1f40, no? > And is

Re: [PATCH] printk: Print cpu number along with time

2014-04-24 Thread Jörn Engel
On Thu, 24 April 2014 12:58:21 -0700, Greg Kroah-Hartman wrote: > > @@ -868,11 +870,20 @@ static size_t print_time(u64 ts, char *buf) > > > > rem_nsec = do_div(ts, 10); > > > > +#ifdef CONFIG_PRINTK_CPU > > + if (!buf) > > + return snprintf(NULL, 0, "[%5lu.00,%02x] "

Re: [PATCH] printk: Print cpu number along with time

2014-04-24 Thread Greg Kroah-Hartman
On Thu, Apr 24, 2014 at 03:40:24PM -0400, Jörn Engel wrote: > On Wed, 23 April 2014 20:52:47 -0400, Jörn Engel wrote: > > > > I use the patch below for some time now. While it doesn't avoid the > > log pollution in the first place, it lessens the impact somewhat. > > Added a config option and po