Re: [PATCH] qspinlock: use signed temporaries for cmpxchg

2020-10-27 Thread Peter Zijlstra
On Tue, Oct 27, 2020 at 05:22:48PM +0100, Arnd Bergmann wrote: > I have already sent patches to move -Wnested-externs and > -Wcast-align from W=2 to W=3, and I guess -Wpointer-sign > could be handled the same way to make the W=2 level useful > again. Works for me ;-), thanks!

Re: [PATCH] qspinlock: use signed temporaries for cmpxchg

2020-10-27 Thread Arnd Bergmann
On Tue, Oct 27, 2020 at 11:32 AM Peter Zijlstra wrote: > > On Tue, Oct 27, 2020 at 09:33:32AM +0100, Arnd Bergmann wrote: > > On Tue, Oct 27, 2020 at 8:47 AM Peter Zijlstra wrote: > > > On Mon, Oct 26, 2020 at 02:03:06PM -0400, Waiman Long wrote: > > > > On 10/26/20 12:57 PM, Arnd Bergmann wrote:

RE: [PATCH] qspinlock: use signed temporaries for cmpxchg

2020-10-27 Thread David Laight
From: Peter Zijlstra > Sent: 27 October 2020 10:33 > > On Tue, Oct 27, 2020 at 09:33:32AM +0100, Arnd Bergmann wrote: > > On Tue, Oct 27, 2020 at 8:47 AM Peter Zijlstra wrote: > > > On Mon, Oct 26, 2020 at 02:03:06PM -0400, Waiman Long wrote: > > > > On 10/26/20 12:57 PM, Arnd Bergmann wrote: > >

Re: [PATCH] qspinlock: use signed temporaries for cmpxchg

2020-10-27 Thread Peter Zijlstra
On Tue, Oct 27, 2020 at 09:33:32AM +0100, Arnd Bergmann wrote: > On Tue, Oct 27, 2020 at 8:47 AM Peter Zijlstra wrote: > > On Mon, Oct 26, 2020 at 02:03:06PM -0400, Waiman Long wrote: > > > On 10/26/20 12:57 PM, Arnd Bergmann wrote: > > > Yes, it shouldn't really matter if the value is defined as

Re: [PATCH] qspinlock: use signed temporaries for cmpxchg

2020-10-27 Thread Arnd Bergmann
On Tue, Oct 27, 2020 at 8:47 AM Peter Zijlstra wrote: > On Mon, Oct 26, 2020 at 02:03:06PM -0400, Waiman Long wrote: > > On 10/26/20 12:57 PM, Arnd Bergmann wrote: > > Yes, it shouldn't really matter if the value is defined as int or u32. > > However, the only caveat that I see is queued_spin_lock

Re: [PATCH] qspinlock: use signed temporaries for cmpxchg

2020-10-27 Thread Peter Zijlstra
On Mon, Oct 26, 2020 at 02:03:06PM -0400, Waiman Long wrote: > On 10/26/20 12:57 PM, Arnd Bergmann wrote: > > From: Arnd Bergmann > > > > When building with W=2, the build log is flooded with > > > > include/asm-generic/qrwlock.h:65:56: warning: pointer targets in passing > > argument 2 of 'ato

Re: [PATCH] qspinlock: use signed temporaries for cmpxchg

2020-10-26 Thread Waiman Long
On 10/26/20 12:57 PM, Arnd Bergmann wrote: From: Arnd Bergmann When building with W=2, the build log is flooded with include/asm-generic/qrwlock.h:65:56: warning: pointer targets in passing argument 2 of 'atomic_try_cmpxchg_acquire' differ in signedness [-Wpointer-sign] include/asm-generic/qr

Re: [PATCH] qspinlock: use signed temporaries for cmpxchg

2020-10-26 Thread Peter Zijlstra
On Mon, Oct 26, 2020 at 05:57:51PM +0100, Arnd Bergmann wrote: > From: Arnd Bergmann > > When building with W=2, the build log is flooded with > > include/asm-generic/qrwlock.h:65:56: warning: pointer targets in passing > argument 2 of 'atomic_try_cmpxchg_acquire' differ in signedness > [-Wpoi