Re: [PATCH] remove PAGE_SIZE from headers_install

2007-08-04 Thread Olaf Hering
On Sun, Jul 15, Mike Frysinger wrote: > On 7/15/07, Olaf Hering <[EMAIL PROTECTED]> wrote: > >On Sat, Jul 14, Mike Frysinger wrote: > >> imo, asm/page.h should just go away for userspace. the attached patch > >> is what i've been using in Gentoo ... but somethings (like an arch or > >> two in

Re: [PATCH] remove PAGE_SIZE from headers_install

2007-08-04 Thread Olaf Hering
On Sun, Jul 15, Mike Frysinger wrote: On 7/15/07, Olaf Hering [EMAIL PROTECTED] wrote: On Sat, Jul 14, Mike Frysinger wrote: imo, asm/page.h should just go away for userspace. the attached patch is what i've been using in Gentoo ... but somethings (like an arch or two in glibc) still

Re: [PATCH] remove PAGE_SIZE from headers_install

2007-07-15 Thread David Woodhouse
On Sun, 2007-07-15 at 02:20 -0500, Mike Frysinger wrote: > i honestly didnt think people would consider it for inclusion as it > was since i ripped out a lot more headers than just asm/page.h ;) So split it up into individual patches. It all looks good to me. -- dwmw2 - To unsubscribe from

Re: [PATCH] remove PAGE_SIZE from headers_install

2007-07-15 Thread David Woodhouse
On Sat, 2007-07-14 at 23:34 +0200, Olaf Hering wrote: > > I would think it would be better to not define it at all. Several > > architectures already don't have PAGE_SIZE visible to userspace in > > any way. > > i386 has it, so everyone uses it. PowerPC lacks it, so nothing we ship in Fedora

Re: [PATCH] remove PAGE_SIZE from headers_install

2007-07-15 Thread Olaf Hering
On Sat, Jul 14, Mike Frysinger wrote: > On 7/14/07, Olaf Hering <[EMAIL PROTECTED]> wrote: > >Declare PAGE_SIZE as getpagesize() for userspace. > >PAGE_SIZE is used in resource.h and shm.h > > > >define PAGE_SIZE in asm-generic/page.h > >guard get_order() with _ARCH_HAS_GET_ORDER for ia64 and

Re: [PATCH] remove PAGE_SIZE from headers_install

2007-07-15 Thread Mike Frysinger
On 7/15/07, Olaf Hering <[EMAIL PROTECTED]> wrote: On Sat, Jul 14, Mike Frysinger wrote: > imo, asm/page.h should just go away for userspace. the attached patch > is what i've been using in Gentoo ... but somethings (like an arch or > two in glibc) still assume asm/page.h is OK. in general

Re: [PATCH] remove PAGE_SIZE from headers_install

2007-07-15 Thread Olaf Hering
On Sat, Jul 14, Mike Frysinger wrote: > imo, asm/page.h should just go away for userspace. the attached patch > is what i've been using in Gentoo ... but somethings (like an arch or > two in glibc) still assume asm/page.h is OK. in general though, > considering asm/page.h has become so

Re: [PATCH] remove PAGE_SIZE from headers_install

2007-07-15 Thread Olaf Hering
On Sat, Jul 14, Mike Frysinger wrote: imo, asm/page.h should just go away for userspace. the attached patch is what i've been using in Gentoo ... but somethings (like an arch or two in glibc) still assume asm/page.h is OK. in general though, considering asm/page.h has become so unreliable

Re: [PATCH] remove PAGE_SIZE from headers_install

2007-07-15 Thread Mike Frysinger
On 7/15/07, Olaf Hering [EMAIL PROTECTED] wrote: On Sat, Jul 14, Mike Frysinger wrote: imo, asm/page.h should just go away for userspace. the attached patch is what i've been using in Gentoo ... but somethings (like an arch or two in glibc) still assume asm/page.h is OK. in general though,

Re: [PATCH] remove PAGE_SIZE from headers_install

2007-07-15 Thread Olaf Hering
On Sat, Jul 14, Mike Frysinger wrote: On 7/14/07, Olaf Hering [EMAIL PROTECTED] wrote: Declare PAGE_SIZE as getpagesize() for userspace. PAGE_SIZE is used in resource.h and shm.h define PAGE_SIZE in asm-generic/page.h guard get_order() with _ARCH_HAS_GET_ORDER for ia64 and xtensa include

Re: [PATCH] remove PAGE_SIZE from headers_install

2007-07-15 Thread David Woodhouse
On Sat, 2007-07-14 at 23:34 +0200, Olaf Hering wrote: I would think it would be better to not define it at all. Several architectures already don't have PAGE_SIZE visible to userspace in any way. i386 has it, so everyone uses it. PowerPC lacks it, so nothing we ship in Fedora relies

Re: [PATCH] remove PAGE_SIZE from headers_install

2007-07-15 Thread David Woodhouse
On Sun, 2007-07-15 at 02:20 -0500, Mike Frysinger wrote: i honestly didnt think people would consider it for inclusion as it was since i ripped out a lot more headers than just asm/page.h ;) So split it up into individual patches. It all looks good to me. -- dwmw2 - To unsubscribe from this

Re: [PATCH] remove PAGE_SIZE from headers_install

2007-07-14 Thread Albert Cahalan
On 7/14/07, David Miller <[EMAIL PROTECTED]> wrote: From: "Albert Cahalan" <[EMAIL PROTECTED]> Date: Sat, 14 Jul 2007 22:48:57 -0400 > A real constant-value PAGE_SIZE is useful and doable. It's bogus to use it. The kernel can get recompiled to arbitrary page sizes on some architectures, so a

Re: [PATCH] remove PAGE_SIZE from headers_install

2007-07-14 Thread David Miller
From: "Albert Cahalan" <[EMAIL PROTECTED]> Date: Sat, 14 Jul 2007 22:48:57 -0400 > A real constant-value PAGE_SIZE is useful and doable. It's bogus to use it. The kernel can get recompiled to arbitrary page sizes on some architectures, so a constat page size assumption cannot work. > It's

Re: [PATCH] remove PAGE_SIZE from headers_install

2007-07-14 Thread H. Peter Anvin
Albert Cahalan wrote: > > A real constant-value PAGE_SIZE is useful and doable. > > It's useful because a getpagesize() can't be used for numerous > things, such as setting the size of an array. > > It's doable, even on architectures that support multiple page > sizes, because ABIs specify

Re: [PATCH] remove PAGE_SIZE from headers_install

2007-07-14 Thread Albert Cahalan
Olaf Hering writes: On Sat, Jul 14, H. Peter Anvin wrote: Olaf Hering wrote: Declare PAGE_SIZE as getpagesize() for userspace. PAGE_SIZE is used in resource.h and shm.h I would think it would be better to not define it at all. Several architectures already don't have PAGE_SIZE visible to

Re: [PATCH] remove PAGE_SIZE from headers_install

2007-07-14 Thread Mike Frysinger
On 7/14/07, Olaf Hering <[EMAIL PROTECTED]> wrote: On Sat, Jul 14, H. Peter Anvin wrote: > Olaf Hering wrote: > > Declare PAGE_SIZE as getpagesize() for userspace. > > PAGE_SIZE is used in resource.h and shm.h > > I would think it would be better to not define it at all. Several > architectures

Re: [PATCH] remove PAGE_SIZE from headers_install

2007-07-14 Thread Mikael Pettersson
On Sat, 14 Jul 2007 14:12:57 -0700, H. Peter Anvin wrote: > Olaf Hering wrote: > > Declare PAGE_SIZE as getpagesize() for userspace. > > PAGE_SIZE is used in resource.h and shm.h > > I would think it would be better to not define it at all. Several > architectures already don't have PAGE_SIZE

Re: [PATCH] remove PAGE_SIZE from headers_install

2007-07-14 Thread Olaf Hering
On Sat, Jul 14, H. Peter Anvin wrote: > Olaf Hering wrote: > > Declare PAGE_SIZE as getpagesize() for userspace. > > PAGE_SIZE is used in resource.h and shm.h > > I would think it would be better to not define it at all. Several > architectures already don't have PAGE_SIZE visible to userspace

Re: [PATCH] remove PAGE_SIZE from headers_install

2007-07-14 Thread H. Peter Anvin
Olaf Hering wrote: > Declare PAGE_SIZE as getpagesize() for userspace. > PAGE_SIZE is used in resource.h and shm.h I would think it would be better to not define it at all. Several architectures already don't have PAGE_SIZE visible to userspace in any way. -hpa - To unsubscribe from

Re: [PATCH] remove PAGE_SIZE from headers_install

2007-07-14 Thread Mike Frysinger
On 7/14/07, Olaf Hering <[EMAIL PROTECTED]> wrote: Declare PAGE_SIZE as getpagesize() for userspace. PAGE_SIZE is used in resource.h and shm.h define PAGE_SIZE in asm-generic/page.h guard get_order() with _ARCH_HAS_GET_ORDER for ia64 and xtensa include asm-generic/page.h in asm/page.h make

Re: [PATCH] remove PAGE_SIZE from headers_install

2007-07-14 Thread Mike Frysinger
On 7/14/07, Olaf Hering [EMAIL PROTECTED] wrote: Declare PAGE_SIZE as getpagesize() for userspace. PAGE_SIZE is used in resource.h and shm.h define PAGE_SIZE in asm-generic/page.h guard get_order() with _ARCH_HAS_GET_ORDER for ia64 and xtensa include asm-generic/page.h in asm/page.h make

Re: [PATCH] remove PAGE_SIZE from headers_install

2007-07-14 Thread H. Peter Anvin
Olaf Hering wrote: Declare PAGE_SIZE as getpagesize() for userspace. PAGE_SIZE is used in resource.h and shm.h I would think it would be better to not define it at all. Several architectures already don't have PAGE_SIZE visible to userspace in any way. -hpa - To unsubscribe from this

Re: [PATCH] remove PAGE_SIZE from headers_install

2007-07-14 Thread Olaf Hering
On Sat, Jul 14, H. Peter Anvin wrote: Olaf Hering wrote: Declare PAGE_SIZE as getpagesize() for userspace. PAGE_SIZE is used in resource.h and shm.h I would think it would be better to not define it at all. Several architectures already don't have PAGE_SIZE visible to userspace in any

Re: [PATCH] remove PAGE_SIZE from headers_install

2007-07-14 Thread Mikael Pettersson
On Sat, 14 Jul 2007 14:12:57 -0700, H. Peter Anvin wrote: Olaf Hering wrote: Declare PAGE_SIZE as getpagesize() for userspace. PAGE_SIZE is used in resource.h and shm.h I would think it would be better to not define it at all. Several architectures already don't have PAGE_SIZE visible to

Re: [PATCH] remove PAGE_SIZE from headers_install

2007-07-14 Thread Mike Frysinger
On 7/14/07, Olaf Hering [EMAIL PROTECTED] wrote: On Sat, Jul 14, H. Peter Anvin wrote: Olaf Hering wrote: Declare PAGE_SIZE as getpagesize() for userspace. PAGE_SIZE is used in resource.h and shm.h I would think it would be better to not define it at all. Several architectures already

Re: [PATCH] remove PAGE_SIZE from headers_install

2007-07-14 Thread Albert Cahalan
Olaf Hering writes: On Sat, Jul 14, H. Peter Anvin wrote: Olaf Hering wrote: Declare PAGE_SIZE as getpagesize() for userspace. PAGE_SIZE is used in resource.h and shm.h I would think it would be better to not define it at all. Several architectures already don't have PAGE_SIZE visible to

Re: [PATCH] remove PAGE_SIZE from headers_install

2007-07-14 Thread H. Peter Anvin
Albert Cahalan wrote: A real constant-value PAGE_SIZE is useful and doable. It's useful because a getpagesize() can't be used for numerous things, such as setting the size of an array. It's doable, even on architectures that support multiple page sizes, because ABIs specify alignment

Re: [PATCH] remove PAGE_SIZE from headers_install

2007-07-14 Thread David Miller
From: Albert Cahalan [EMAIL PROTECTED] Date: Sat, 14 Jul 2007 22:48:57 -0400 A real constant-value PAGE_SIZE is useful and doable. It's bogus to use it. The kernel can get recompiled to arbitrary page sizes on some architectures, so a constat page size assumption cannot work. It's useful

Re: [PATCH] remove PAGE_SIZE from headers_install

2007-07-14 Thread Albert Cahalan
On 7/14/07, David Miller [EMAIL PROTECTED] wrote: From: Albert Cahalan [EMAIL PROTECTED] Date: Sat, 14 Jul 2007 22:48:57 -0400 A real constant-value PAGE_SIZE is useful and doable. It's bogus to use it. The kernel can get recompiled to arbitrary page sizes on some architectures, so a constat