Re: [PATCH] rtl8712:Fix checkpatch warning

2015-06-29 Thread Larry Finger
On 06/29/2015 11:29 PM, Sudip Mukherjee wrote: On Tue, Jun 30, 2015 at 01:27:47AM +0530, Ravi Teja Darbha wrote: 1. Fix line over 80 characters warning. 2. The checkpatch warning at line 499 seems to be false positive. WARNING: else is not generally useful after a break or return #499: FILE: rt

Re: [PATCH] rtl8712:Fix checkpatch warning

2015-06-29 Thread Sudip Mukherjee
On Tue, Jun 30, 2015 at 01:27:47AM +0530, Ravi Teja Darbha wrote: > > 1. Fix line over 80 characters warning. > 2. The checkpatch warning at line 499 seems to be false positive. > WARNING: else is not generally useful after a break or return > #499: FILE: rtl8712_recv.c:499: > +return

Re: [PATCH] rtl8712:Fix checkpatch warning

2015-06-29 Thread Greg KH
On Tue, Jun 30, 2015 at 01:27:47AM +0530, Ravi Teja Darbha wrote: > > 1. Fix line over 80 characters warning. Great, but: > 2. The checkpatch warning at line 499 seems to be false positive. > WARNING: else is not generally useful after a break or return > #499: FILE: rtl8712_recv.c:499: > +