Re: [PATCH] s390: correct misuses of module_put in appldata_generic_handler.

Delicate design! thanks for replying, sorry for the trouble On Tue, Mar 18, 2014 at 9:34 PM, Gerald Schaefer wrote: > On Tue, 18 Mar 2014 09:24:55 +0800 > Zhouyi Zhou wrote: > >> Thanks Gerald for reviewing and sorry for not elaborated it in the e-mail. >> >> Firstly, I think you can't call mod

Re: [PATCH] s390: correct misuses of module_put in appldata_generic_handler.

On Tue, 18 Mar 2014 09:24:55 +0800 Zhouyi Zhou wrote: > Thanks Gerald for reviewing and sorry for not elaborated it in the e-mail. > > Firstly, I think you can't call module_put after fail try_module_get There is another try_module_get() in this function before that, so I need to call module_pu

Re: [PATCH] s390: correct misuses of module_put in appldata_generic_handler.

Thanks Gerald for reviewing and sorry for not elaborated it in the e-mail. Firstly, I think you can't call module_put after fail try_module_get Secondly, there exists duplicate module_put on the program path (the last one is before return 0) On Mon, Mar 17, 2014 at 9:28 PM, Gerald Schaefer wrot

Re: [PATCH] s390: correct misuses of module_put in appldata_generic_handler.

On Sat, 15 Mar 2014 21:35:40 +0800 Zhouyi Zhou wrote: > correct misuses of module_put in appldata_generic_handler Sorry, I don't see any misuse, could you elaborate? > > Signed-off-by: Zhouyi Zhou > --- > arch/s390/appldata/appldata_base.c | 3 --- > 1 file changed, 3 deletions(-) > > diff