Re: [PATCH] s390:ftrace: add save_stack_trace_regs()

2016-02-01 Thread Heiko Carstens
On Fri, Jan 29, 2016 at 10:50:28AM +0530, Pratyush Anand wrote: > Implement save_stack_trace_regs, so that stacktrace of a kprobe events can > be obtained. > > Without this we see following warning: > "save_stack_trace_regs() not implemented yet." > when we execute: > echo stacktrace > /sys/kernel

Re: [PATCH] s390:ftrace: add save_stack_trace_regs()

2016-01-29 Thread Heiko Carstens
On Fri, Jan 29, 2016 at 11:56:59AM -0500, Steven Rostedt wrote: > On Fri, 29 Jan 2016 17:49:18 +0100 > Heiko Carstens wrote: > > > Which looks much better. The stack tracer also works again! > > Great! Although, it shouldn't have affected the stack tracing of kprobe > events :-/ Yes, you're ab

Re: [PATCH] s390:ftrace: add save_stack_trace_regs()

2016-01-29 Thread Steven Rostedt
On Fri, 29 Jan 2016 17:49:18 +0100 Heiko Carstens wrote: > Which looks much better. The stack tracer also works again! Great! Although, it shouldn't have affected the stack tracing of kprobe events :-/ Although the previous commit I showed would. > > If the above is supposed to be the final

Re: [PATCH] s390:ftrace: add save_stack_trace_regs()

2016-01-29 Thread Heiko Carstens
On Fri, Jan 29, 2016 at 10:22:41AM -0500, Steven Rostedt wrote: > > No, that doesn't fix it (current Linus' master): > > > > # uname -a > > Linux p2345007 4.5.0-rc1-00032-g26cd83670f2f #26 SMP Fri Jan 29 15:39:47 > > CET 2016 s390x s390x s390x GNU/Linux > > > > # cat stack_max_size > > 4496 > >

Re: [PATCH] s390:ftrace: add save_stack_trace_regs()

2016-01-29 Thread Steven Rostedt
On Fri, 29 Jan 2016 15:45:22 +0100 Heiko Carstens wrote: > On Fri, Jan 29, 2016 at 08:59:36AM -0500, Steven Rostedt wrote: > > On Fri, 29 Jan 2016 13:57:49 +0100 > > Heiko Carstens wrote: > > > > > Surpringly it wasn't one of my own patches which broke the stack tracer on > > > s390, but one

Re: [PATCH] s390:ftrace: add save_stack_trace_regs()

2016-01-29 Thread Heiko Carstens
On Fri, Jan 29, 2016 at 08:59:36AM -0500, Steven Rostedt wrote: > On Fri, 29 Jan 2016 13:57:49 +0100 > Heiko Carstens wrote: > > > Surpringly it wasn't one of my own patches which broke the stack tracer on > > s390, but one from Steven: > > > > 72ac426a5bb0 ("tracing: Clean up stack tracing and

Re: [PATCH] s390:ftrace: add save_stack_trace_regs()

2016-01-29 Thread Steven Rostedt
On Fri, 29 Jan 2016 13:57:49 +0100 Heiko Carstens wrote: > Surpringly it wasn't one of my own patches which broke the stack tracer on > s390, but one from Steven: > > 72ac426a5bb0 ("tracing: Clean up stack tracing and fix fentry updates") > > Now I only need to figure out why :) Try this one?

Re: [PATCH] s390:ftrace: add save_stack_trace_regs()

2016-01-29 Thread Heiko Carstens
On Fri, Jan 29, 2016 at 09:54:47AM +0100, Heiko Carstens wrote: > On Fri, Jan 29, 2016 at 10:50:28AM +0530, Pratyush Anand wrote: > > Implement save_stack_trace_regs, so that stacktrace of a kprobe events can > > be obtained. > > > > Without this we see following warning: > > "save_stack_trace_reg

Re: [PATCH] s390:ftrace: add save_stack_trace_regs()

2016-01-29 Thread Heiko Carstens
On Fri, Jan 29, 2016 at 10:50:28AM +0530, Pratyush Anand wrote: > Implement save_stack_trace_regs, so that stacktrace of a kprobe events can > be obtained. > > Without this we see following warning: > "save_stack_trace_regs() not implemented yet." > when we execute: > echo stacktrace > /sys/kernel