Re: [PATCH] samples/rpmsg: Introduce a module parameter for message count

2018-10-08 Thread Suman Anna
Hi Bjorn, On 10/06/2018 01:22 AM, Bjorn Andersson wrote: > On Tue 11 Sep 10:46 PDT 2018, Suman Anna wrote: > >> The current rpmsg_client_sample uses a fixed number of messages to >> be sent to each instance. This is currently set at 100. Introduce >> an optional module parameter 'count' so that t

Re: [PATCH] samples/rpmsg: Introduce a module parameter for message count

2018-10-06 Thread Vinod
On 05-10-18, 23:22, Bjorn Andersson wrote: > On Tue 11 Sep 10:46 PDT 2018, Suman Anna wrote: > > > The current rpmsg_client_sample uses a fixed number of messages to > > be sent to each instance. This is currently set at 100. Introduce > > an optional module parameter 'count' so that the number of

Re: [PATCH] samples/rpmsg: Introduce a module parameter for message count

2018-10-05 Thread Bjorn Andersson
On Tue 11 Sep 10:46 PDT 2018, Suman Anna wrote: > The current rpmsg_client_sample uses a fixed number of messages to > be sent to each instance. This is currently set at 100. Introduce > an optional module parameter 'count' so that the number of messages > to be exchanged can be made flexible. >

Re: [PATCH] samples/rpmsg: Introduce a module parameter for message count

2018-10-01 Thread Suman Anna
Hi Trilok, On 09/11/2018 01:17 PM, Trilok Soni wrote: > Bjorn, > >>     #define MSG    "hello world!" >> -#define MSG_LIMIT    100 >> + >> +static int count = 100; >> +module_param(count, int, 0644); > > I thought Greg KH doesn't want any new code to have module_param call, > right? Are we O

Re: [PATCH] samples/rpmsg: Introduce a module parameter for message count

2018-09-11 Thread Trilok Soni
Bjorn, #define MSG "hello world!" -#define MSG_LIMIT 100 + +static int count = 100; +module_param(count, int, 0644); I thought Greg KH doesn't want any new code to have module_param call, right? Are we Ok here or I am missing something here. -- ---Trilok Soni Qualcomm Innovation