Re: [PATCH] samples: build fix

2008-02-14 Thread Sam Ravnborg
On Thu, Feb 14, 2008 at 03:04:04PM -0500, Mathieu Desnoyers wrote: > * Sam Ravnborg ([EMAIL PROTECTED]) wrote: > > On Thu, Feb 14, 2008 at 08:27:52AM -0500, Mathieu Desnoyers wrote: > > > * Roland McGrath ([EMAIL PROTECTED]) wrote: > > > > > > > > The samples/ subdirectory contains only modules. >

Re: [PATCH] samples: build fix

2008-02-14 Thread Sam Ravnborg
On Thu, Feb 14, 2008 at 12:02:57PM -0800, Roland McGrath wrote: > I don't have any axe to grind here, I just could not figure out how to get > the samples/ modules built (without resorting to make M=.../samples/foo and > clobbering my source directory). > If there is another plan, point me to its

Re: [PATCH] samples: build fix

2008-02-14 Thread Randy Dunlap
On Thu, 14 Feb 2008 12:02:57 -0800 (PST) Roland McGrath wrote: > I don't have any axe to grind here, I just could not figure out how to get > the samples/ modules built (without resorting to make M=.../samples/foo and > clobbering my source directory). If there is another plan, point me to its >

Re: [PATCH] samples: build fix

2008-02-14 Thread Mathieu Desnoyers
* Sam Ravnborg ([EMAIL PROTECTED]) wrote: > On Thu, Feb 14, 2008 at 08:27:52AM -0500, Mathieu Desnoyers wrote: > > * Roland McGrath ([EMAIL PROTECTED]) wrote: > > > > > > The samples/ subdirectory contains only modules. > > > But the only make run done there is in commands for vmlinux. > > > I can

Re: [PATCH] samples: build fix

2008-02-14 Thread Roland McGrath
I don't have any axe to grind here, I just could not figure out how to get the samples/ modules built (without resorting to make M=.../samples/foo and clobbering my source directory). If there is another plan, point me to its documentation. I can't see the point of the Kconfig option for samples

Re: [PATCH] samples: build fix

2008-02-14 Thread Sam Ravnborg
On Thu, Feb 14, 2008 at 08:27:52AM -0500, Mathieu Desnoyers wrote: > * Roland McGrath ([EMAIL PROTECTED]) wrote: > > > > The samples/ subdirectory contains only modules. > > But the only make run done there is in commands for vmlinux. > > I can't see why this was ever done in this nonstandard fash

Re: [PATCH] samples: build fix

2008-02-14 Thread Roland McGrath
> Sam, is this ok with the samples intent ? I think as long as we do not > include them with the kernel image and have a "make samples" to build > them, it's ok. Having them built upon make modules seems like a good > idea to me. I"m not sure what you mean by "with the kernel image". AFAICT, eve

Re: [PATCH] samples: build fix

2008-02-14 Thread Mathieu Desnoyers
* Roland McGrath ([EMAIL PROTECTED]) wrote: > > The samples/ subdirectory contains only modules. > But the only make run done there is in commands for vmlinux. > I can't see why this was ever done in this nonstandard fashion. > As things stand, the modules don't get built by 'make modules'. > > I