Re: [PATCH] sched/fair: Introduce fits_capacity()

2019-07-17 Thread Peter Zijlstra
On Wed, Jul 17, 2019 at 04:03:56PM +0530, Viresh Kumar wrote: > On 04-06-19, 12:31, Viresh Kumar wrote: > > The same formula to check utilization against capacity (after > > considering capacity_margin) is already used at 5 different locations. > > > > This patch creates a new macro, fits_capacity

Re: [PATCH] sched/fair: Introduce fits_capacity()

2019-07-17 Thread Viresh Kumar
On 04-06-19, 12:31, Viresh Kumar wrote: > The same formula to check utilization against capacity (after > considering capacity_margin) is already used at 5 different locations. > > This patch creates a new macro, fits_capacity(), which can be used from > all these locations without exposing the de

Re: [PATCH] sched/fair: Introduce fits_capacity()

2019-06-18 Thread Quentin Perret
On Tuesday 18 Jun 2019 at 10:36:56 (+0200), Rafael J. Wysocki wrote: > On Tue, Jun 18, 2019 at 10:25 AM Quentin Perret > wrote: > > > > On Tuesday 18 Jun 2019 at 10:10:48 (+0200), Rafael J. Wysocki wrote: > > > On Tue, Jun 18, 2019 at 9:47 AM Viresh Kumar > > > wrote: > > > > > > > > On 18-06-1

Re: [PATCH] sched/fair: Introduce fits_capacity()

2019-06-18 Thread Rafael J. Wysocki
On Tue, Jun 18, 2019 at 10:25 AM Quentin Perret wrote: > > On Tuesday 18 Jun 2019 at 10:10:48 (+0200), Rafael J. Wysocki wrote: > > On Tue, Jun 18, 2019 at 9:47 AM Viresh Kumar > > wrote: > > > > > > On 18-06-19, 09:26, Rafael J. Wysocki wrote: > > > > On Tue, Jun 18, 2019 at 5:12 AM Viresh Kuma

Re: [PATCH] sched/fair: Introduce fits_capacity()

2019-06-18 Thread Quentin Perret
On Tuesday 18 Jun 2019 at 10:10:48 (+0200), Rafael J. Wysocki wrote: > On Tue, Jun 18, 2019 at 9:47 AM Viresh Kumar wrote: > > > > On 18-06-19, 09:26, Rafael J. Wysocki wrote: > > > On Tue, Jun 18, 2019 at 5:12 AM Viresh Kumar > > > wrote: > > > > > > > > +Rafael > > > > > > > > On 17-06-19, 17:

Re: [PATCH] sched/fair: Introduce fits_capacity()

2019-06-18 Thread Quentin Perret
On Tuesday 18 Jun 2019 at 13:17:28 (+0530), Viresh Kumar wrote: > On 18-06-19, 09:26, Rafael J. Wysocki wrote: > > On Tue, Jun 18, 2019 at 5:12 AM Viresh Kumar > > wrote: > > > > > > +Rafael > > > > > > On 17-06-19, 17:02, Peter Zijlstra wrote: > > > > On Thu, Jun 06, 2019 at 08:22:04AM +0530, Vi

Re: [PATCH] sched/fair: Introduce fits_capacity()

2019-06-18 Thread Rafael J. Wysocki
On Tue, Jun 18, 2019 at 9:47 AM Viresh Kumar wrote: > > On 18-06-19, 09:26, Rafael J. Wysocki wrote: > > On Tue, Jun 18, 2019 at 5:12 AM Viresh Kumar > > wrote: > > > > > > +Rafael > > > > > > On 17-06-19, 17:02, Peter Zijlstra wrote: > > > > On Thu, Jun 06, 2019 at 08:22:04AM +0530, Viresh Kuma

Re: [PATCH] sched/fair: Introduce fits_capacity()

2019-06-18 Thread Viresh Kumar
On 18-06-19, 09:26, Rafael J. Wysocki wrote: > On Tue, Jun 18, 2019 at 5:12 AM Viresh Kumar wrote: > > > > +Rafael > > > > On 17-06-19, 17:02, Peter Zijlstra wrote: > > > On Thu, Jun 06, 2019 at 08:22:04AM +0530, Viresh Kumar wrote: > > > > Hmm, even if the values are same currently I am not sure

Re: [PATCH] sched/fair: Introduce fits_capacity()

2019-06-18 Thread Rafael J. Wysocki
On Tue, Jun 18, 2019 at 5:12 AM Viresh Kumar wrote: > > +Rafael > > On 17-06-19, 17:02, Peter Zijlstra wrote: > > On Thu, Jun 06, 2019 at 08:22:04AM +0530, Viresh Kumar wrote: > > > Hmm, even if the values are same currently I am not sure if we want > > > the same for ever. I will write a patch fo

Re: [PATCH] sched/fair: Introduce fits_capacity()

2019-06-17 Thread Viresh Kumar
+Rafael On 17-06-19, 17:02, Peter Zijlstra wrote: > On Thu, Jun 06, 2019 at 08:22:04AM +0530, Viresh Kumar wrote: > > Hmm, even if the values are same currently I am not sure if we want > > the same for ever. I will write a patch for it though, if Peter/Rafael > > feel the same as you. > > Is it

Re: [PATCH] sched/fair: Introduce fits_capacity()

2019-06-17 Thread Peter Zijlstra
On Thu, Jun 06, 2019 at 08:22:04AM +0530, Viresh Kumar wrote: > Hmm, even if the values are same currently I am not sure if we want > the same for ever. I will write a patch for it though, if Peter/Rafael > feel the same as you. Is it really the same variable or just two numbers that happen to be

Re: [PATCH] sched/fair: Introduce fits_capacity()

2019-06-06 Thread Quentin Perret
On Thursday 06 Jun 2019 at 08:22:04 (+0530), Viresh Kumar wrote: > On 05-06-19, 10:16, Quentin Perret wrote: > > Hi Viresh, > > > > On Tuesday 04 Jun 2019 at 12:31:52 (+0530), Viresh Kumar wrote: > > > The same formula to check utilization against capacity (after > > > considering capacity_margin)

Re: [PATCH] sched/fair: Introduce fits_capacity()

2019-06-05 Thread Viresh Kumar
On 04-06-19, 08:59, Peter Oskolkov wrote: > On Tue, Jun 4, 2019 at 12:02 AM Viresh Kumar wrote: > > > > The same formula to check utilization against capacity (after > > considering capacity_margin) is already used at 5 different locations. > > > > This patch creates a new macro, fits_capacity(),

Re: [PATCH] sched/fair: Introduce fits_capacity()

2019-06-05 Thread Viresh Kumar
On 05-06-19, 10:16, Quentin Perret wrote: > Hi Viresh, > > On Tuesday 04 Jun 2019 at 12:31:52 (+0530), Viresh Kumar wrote: > > The same formula to check utilization against capacity (after > > considering capacity_margin) is already used at 5 different locations. > > > > This patch creates a new

Re: [PATCH] sched/fair: Introduce fits_capacity()

2019-06-05 Thread Quentin Perret
Hi Viresh, On Tuesday 04 Jun 2019 at 12:31:52 (+0530), Viresh Kumar wrote: > The same formula to check utilization against capacity (after > considering capacity_margin) is already used at 5 different locations. > > This patch creates a new macro, fits_capacity(), which can be used from > all the

Re: [PATCH] sched/fair: Introduce fits_capacity()

2019-06-04 Thread Peter Oskolkov
On Tue, Jun 4, 2019 at 12:02 AM Viresh Kumar wrote: > > The same formula to check utilization against capacity (after > considering capacity_margin) is already used at 5 different locations. > > This patch creates a new macro, fits_capacity(), which can be used from > all these locations without e