Re: [PATCH] sched/numa: do not balance tasks onto isolated cpus

2018-07-25 Thread jiang.biao2
> On Wed, Jul 25, 2018 at 08:30:03AM +0800, jiang.bi...@zte.com.cn wrote: >> I do find some(very few) Co-Authored-by in git logs, and we'll try to avoid >> using that. Sometimes little patches may include much background work of >> different people.:) > > I sometimes use Debugged-by: to attribute t

Re: [PATCH] sched/numa: do not balance tasks onto isolated cpus

2018-07-25 Thread Peter Zijlstra
On Wed, Jul 25, 2018 at 08:30:03AM +0800, jiang.bi...@zte.com.cn wrote: > I do find some(very few) Co-Authored-by in git logs, and we'll try to avoid > using that. Sometimes little patches may include much background work of > different people.:) I sometimes use Debugged-by: to attribute the some

Re: [PATCH] sched/numa: do not balance tasks onto isolated cpus

2018-07-24 Thread jiang.biao2
Hi, > On Tue, Jul 24, 2018 at 09:11:37AM +0800, jiang.bi...@zte.com.cn wrote: > >> >> Signed-off-by: Cheng Lin >> >> Signed-off-by: Tan Hu >> >> Signed-off-by: Jiang Biao >> > >> >This SoB chain is invalid. > >> Mm, we don't quite understand what the *Signed-off-by* precisely means, >> Does it o

Re: [PATCH] sched/numa: do not balance tasks onto isolated cpus

2018-07-24 Thread Peter Zijlstra
On Tue, Jul 24, 2018 at 09:11:37AM +0800, jiang.bi...@zte.com.cn wrote: > >> Signed-off-by: Cheng Lin > >> Signed-off-by: Tan Hu > >> Signed-off-by: Jiang Biao > > > >This SoB chain is invalid. > Mm, we don't quite understand what the *Signed-off-by* precisely means, > Does it only mean DCO(d

Re: [PATCH] sched/numa: do not balance tasks onto isolated cpus

2018-07-23 Thread jiang.biao2
> > On Mon, Jul 23, 2018 at 01:39:30PM +0800, Chen Lin wrote: >> From: Chen Lin >> >> NUMA balancing has not taken *isolcpus(isolated cpus)* into >> consideration. It may migrate tasks onto isolated cpus and the >> migrated tasks will never escape from the isolated cpus, which will >> break the is

Re: [PATCH] sched/numa: do not balance tasks onto isolated cpus

2018-07-23 Thread kbuild test robot
Hi Chen, Thank you for the patch! Yet something to improve: [auto build test ERROR on tip/sched/core] [also build test ERROR on v4.18-rc6 next-20180723] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/c

Re: [PATCH] sched/numa: do not balance tasks onto isolated cpus

2018-07-23 Thread kbuild test robot
Hi Chen, Thank you for the patch! Yet something to improve: [auto build test ERROR on tip/sched/core] [also build test ERROR on v4.18-rc6 next-20180723] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url: https://github.com/0day-ci/linux/c

Re: [PATCH] sched/numa: do not balance tasks onto isolated cpus

2018-07-23 Thread Peter Zijlstra
On Mon, Jul 23, 2018 at 01:39:30PM +0800, Chen Lin wrote: > From: Chen Lin > > NUMA balancing has not taken *isolcpus(isolated cpus)* into > consideration. It may migrate tasks onto isolated cpus and the > migrated tasks will never escape from the isolated cpus, which will > break the isolation