Re: [PATCH] scsi: bnx2i: make bnx2i_process_iscsi_error simpler and more robust

On Wed, 10 Mar 2021 23:16:02 +0100, Rasmus Villemoes wrote: > Instead of strcpy'ing into a stack buffer, just let additional_notice > point to a string literal living in .rodata. This is better in a few > ways: > > - Smaller .text - instead of gcc compiling the strcpys as a bunch of >

Re: [PATCH] scsi: bnx2i: make bnx2i_process_iscsi_error simpler and more robust

Rasmus, > Instead of strcpy'ing into a stack buffer, just let additional_notice > point to a string literal living in .rodata. This is better in a few > ways: Applied to 5.13/scsi-staging, thanks! -- Martin K. Petersen Oracle Linux Engineering