Re: [PATCH] scsi: sym53c8xx_2: remove redundant assignment to retv

2019-08-13 Thread Dan Carpenter
On Fri, Aug 09, 2019 at 11:17:33AM -0700, Matthew Wilcox wrote: > On Fri, Aug 09, 2019 at 06:59:32PM +0100, Colin King wrote: > > Variable retv is initialized to a value that is never read and it > > is re-assigned later. The initialization is redundant and can be > > removed. > > Acked-by: Matthe

Re: [PATCH] scsi: sym53c8xx_2: remove redundant assignment to retv

2019-08-12 Thread Martin K. Petersen
Colin, > Variable retv is initialized to a value that is never read and it is > re-assigned later. The initialization is redundant and can be removed. Applied to 5.4/scsi-queue, thanks! -- Martin K. Petersen Oracle Linux Engineering

Re: [PATCH] scsi: sym53c8xx_2: remove redundant assignment to retv

2019-08-09 Thread Matthew Wilcox
On Fri, Aug 09, 2019 at 06:59:32PM +0100, Colin King wrote: > Variable retv is initialized to a value that is never read and it > is re-assigned later. The initialization is redundant and can be > removed. Acked-by: Matthew Wilcox (Oracle) Seems like a bit of a pointless class of warnings, given