Re: [PATCH] seclvl: use securityfs

2005-08-09 Thread serue
Quoting James Morris ([EMAIL PROTECTED]): > On Mon, 8 Aug 2005, [EMAIL PROTECTED] wrote: > > This looks like a nice cleanup. > > > + > > + if (count < 0 || count >= PAGE_SIZE) > > + return -ENOMEM; > > + if (*ppos != 0) { > > + return -EINVAL; > > + } > > Why is the fir

Re: [PATCH] seclvl: use securityfs

2005-08-08 Thread James Morris
On Mon, 8 Aug 2005, [EMAIL PROTECTED] wrote: This looks like a nice cleanup. > + > + if (count < 0 || count >= PAGE_SIZE) > + return -ENOMEM; > + if (*ppos != 0) { > + return -EINVAL; > + } Why is the first error there -ENOMEM and not -EINVAL? - James -- Ja