Re: [PATCH] selftests: mm: fix the incorrect usage() info of khugepaged

2024-10-17 Thread Anshuman Khandual
On 10/17/24 12:44, Andrew Morton wrote: > On Thu, 17 Oct 2024 12:31:31 +0530 Anshuman Khandual > wrote: > >> On 10/15/24 07:32, Nanyong Sun wrote: >>> The mount option of tmpfs should be huge=advise, not madvise >>> which is not supported and may mislead the users. >> Agreed. >> >>> Fixes: 1b

Re: [PATCH] selftests: mm: fix the incorrect usage() info of khugepaged

2024-10-17 Thread Andrew Morton
On Thu, 17 Oct 2024 12:31:31 +0530 Anshuman Khandual wrote: > On 10/15/24 07:32, Nanyong Sun wrote: > > The mount option of tmpfs should be huge=advise, not madvise > > which is not supported and may mislead the users. > > Agreed. > > > > > Fixes: 1b03d0d558a2 ("selftests/vm: add thp collapse

Re: [PATCH] selftests: mm: fix the incorrect usage() info of khugepaged

2024-10-17 Thread Anshuman Khandual
On 10/15/24 07:32, Nanyong Sun wrote: > The mount option of tmpfs should be huge=advise, not madvise > which is not supported and may mislead the users. Agreed. > > Fixes: 1b03d0d558a2 ("selftests/vm: add thp collapse file and tmpfs testing") But nothing is really broken here. This just fixes u

Re: [PATCH] selftests: mm: fix the incorrect usage() info of khugepaged

2024-10-14 Thread Baolin Wang
On 2024/10/15 10:02, Nanyong Sun wrote: The mount option of tmpfs should be huge=advise, not madvise which is not supported and may mislead the users. Fixes: 1b03d0d558a2 ("selftests/vm: add thp collapse file and tmpfs testing") Signed-off-by: Nanyong Sun LGTM. Reviewed-by: Baolin Wang