Re: [PATCH] selinux: fix memory leak on node_ptr on error return path

2016-03-22 Thread Colin Ian King
On 22/03/16 21:35, Paul Moore wrote: > On Tue, Mar 22, 2016 at 4:28 PM, Serge E. Hallyn wrote: >> Quoting Colin King (colin.k...@canonical.com): >>> From: Colin Ian King >>> >>> node_ptr is not being free'd if the list allocation fails, fix >>> this by kfree'ing it before exiting on the error pat

Re: [PATCH] selinux: fix memory leak on node_ptr on error return path

2016-03-22 Thread Paul Moore
On Tue, Mar 22, 2016 at 4:28 PM, Serge E. Hallyn wrote: > Quoting Colin King (colin.k...@canonical.com): >> From: Colin Ian King >> >> node_ptr is not being free'd if the list allocation fails, fix >> this by kfree'ing it before exiting on the error path. >> >> Signed-off-by: Colin Ian King > >

Re: [PATCH] selinux: fix memory leak on node_ptr on error return path

2016-03-22 Thread Serge E. Hallyn
Quoting Colin King (colin.k...@canonical.com): > From: Colin Ian King > > node_ptr is not being free'd if the list allocation fails, fix > this by kfree'ing it before exiting on the error path. > > Signed-off-by: Colin Ian King Hi, I'm not very familiar with this code any more, but are you su