Re: [PATCH] serial: set RTS and DTR if flow is 'r' --- resend

2007-05-14 Thread Yinghai Lu
Russell King wrote: On Mon, May 14, 2007 at 12:46:27PM -0700, Yinghai Lu wrote: I don't want to put that there. the problem is serial8250_set_mctrl called by will clear DTR bit. We're at a stalemate then. How about put that line into serial8250_console_setup or serial8250_isa_ini

Re: [PATCH] serial: set RTS and DTR if flow is 'r' --- resend

2007-05-14 Thread Russell King
On Mon, May 14, 2007 at 12:46:27PM -0700, Yinghai Lu wrote: > Russell King wrote: > >Still wrong, and unfortunately you haven't understood what I was saying > >at all because this is worse. ;( > > > >Do not put the code in serial8250_set_termios. It is the wrong place. > > > > I don't want to p

Re: [PATCH] serial: set RTS and DTR if flow is 'r' --- resend

2007-05-14 Thread Yinghai Lu
Russell King wrote: Still wrong, and unfortunately you haven't understood what I was saying at all because this is worse. ;( Do not put the code in serial8250_set_termios. It is the wrong place. I don't want to put that there. the problem is serial8250_set_mctrl called by will clear DTR b

Re: [PATCH] serial: set RTS and DTR if flow is 'r' --- resend

2007-05-14 Thread Russell King
On Mon, May 14, 2007 at 12:04:44PM -0700, Yinghai Lu wrote: > Russell King wrote: > >There may be some sense, however, in allowing DTR to be permanently > >raised for serial consoles. However, I would err on caution since > >DTR is used to reliably instruct modems to drop the line, so making > >su

Re: [PATCH] serial: set RTS and DTR if flow is 'r' --- resend

2007-05-14 Thread Yinghai Lu
Russell King wrote: There may be some sense, however, in allowing DTR to be permanently raised for serial consoles. However, I would err on caution since DTR is used to reliably instruct modems to drop the line, so making such a change would be undesirable for those folk. please check follow

Re: [PATCH] serial: set RTS and DTR if flow is 'r' --- resend

2007-05-14 Thread Russell King
On Mon, May 14, 2007 at 10:57:36AM -0700, Yinghai Lu wrote: > [PATCH] serial: set RTS and DTR if flow is 'r' > > if the serial console flow is set to 'r', We need to set RTS and DTR. > Some UARTs on other side need these bit set, otherwise will not send > char to or > receive char from the host t