Re: [PATCH] serial-uartlite: Fix null-ptr-deref in ulite_exit

2019-05-23 Thread Michal Simek
On 23. 05. 19 14:31, Johan Hovold wrote: > On Thu, May 23, 2019 at 12:46:38PM +0200, Michal Simek wrote: >> Hi Johan, >> >> On 23. 05. 19 11:18, Johan Hovold wrote: >>> On Tue, May 21, 2019 at 12:10:59PM +0200, Greg Kroah-Hartman wrote: On Fri, May 17, 2019 at 09:55:02AM +0200, Johan Hovold wr

Re: [PATCH] serial-uartlite: Fix null-ptr-deref in ulite_exit

2019-05-23 Thread Johan Hovold
On Thu, May 23, 2019 at 12:46:38PM +0200, Michal Simek wrote: > Hi Johan, > > On 23. 05. 19 11:18, Johan Hovold wrote: > > On Tue, May 21, 2019 at 12:10:59PM +0200, Greg Kroah-Hartman wrote: > >> On Fri, May 17, 2019 at 09:55:02AM +0200, Johan Hovold wrote: > >>> On Thu, May 16, 2019 at 12:09:31PM

Re: [PATCH] serial-uartlite: Fix null-ptr-deref in ulite_exit

2019-05-23 Thread Michal Simek
Hi Johan, On 23. 05. 19 11:18, Johan Hovold wrote: > On Tue, May 21, 2019 at 12:10:59PM +0200, Greg Kroah-Hartman wrote: >> On Fri, May 17, 2019 at 09:55:02AM +0200, Johan Hovold wrote: >>> On Thu, May 16, 2019 at 12:09:31PM +0800, YueHaibing wrote: If ulite_probe is not called or failed to r

Re: [PATCH] serial-uartlite: Fix null-ptr-deref in ulite_exit

2019-05-23 Thread Johan Hovold
On Tue, May 21, 2019 at 12:10:59PM +0200, Greg Kroah-Hartman wrote: > On Fri, May 17, 2019 at 09:55:02AM +0200, Johan Hovold wrote: > > On Thu, May 16, 2019 at 12:09:31PM +0800, YueHaibing wrote: > > > If ulite_probe is not called or failed to registed > > > uart_register_driver, unload the module

Re: [PATCH] serial-uartlite: Fix null-ptr-deref in ulite_exit

2019-05-21 Thread Greg KH
On Fri, May 17, 2019 at 09:55:02AM +0200, Johan Hovold wrote: > On Thu, May 16, 2019 at 12:09:31PM +0800, YueHaibing wrote: > > If ulite_probe is not called or failed to registed > > uart_register_driver, unload the module will call > > uart_unregister_driver, which will tigger NULL > > pointer der

Re: [PATCH] serial-uartlite: Fix null-ptr-deref in ulite_exit

2019-05-17 Thread Johan Hovold
On Thu, May 16, 2019 at 12:09:31PM +0800, YueHaibing wrote: > If ulite_probe is not called or failed to registed > uart_register_driver, unload the module will call > uart_unregister_driver, which will tigger NULL > pointer dereference like this: > > BUG: KASAN: null-ptr-deref in tty_unregister_dr

Re: [PATCH] serial-uartlite: Fix null-ptr-deref in ulite_exit

2019-05-16 Thread Shubhrajyoti Datta
Hi YueHaibing, Thanks for the patch. On Thu, May 16, 2019 at 9:42 AM YueHaibing wrote: > > If ulite_probe is not called or failed to registed s/registed/register > uart_register_driver, unload the module will call > uart_unregister_driver, which will tigger NULL s/tigger/trigger > pointer derefer